From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v1] PM / devfreq: exynos-nocp : Handle return value of clk_prepare_enable Date: Wed, 24 May 2017 10:56:53 +0900 Message-ID: <5924E865.6030105@samsung.com> References: <1495191035-15882-1-git-send-email-arvind.yadav.cs@gmail.com> <59240441.9090208@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:38817 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbdEXB44 (ORCPT ); Tue, 23 May 2017 21:56:56 -0400 In-reply-to: <59240441.9090208@samsung.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Arvind Yadav , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, kgene@kernel.org, javier@osg.samsung.com Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org On 2017년 05월 23일 18:43, Chanwoo Choi wrote: > Hi Arvind, > > On 2017년 05월 19일 19:50, Arvind Yadav wrote: >> clk_prepare_enable() can fail here and we must check its return value. >> >> Signed-off-by: Arvind Yadav >> --- >> drivers/devfreq/event/exynos-nocp.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c >> index 5c3e7b1..f6e7956 100644 >> --- a/drivers/devfreq/event/exynos-nocp.c >> +++ b/drivers/devfreq/event/exynos-nocp.c >> @@ -267,7 +267,11 @@ static int exynos_nocp_probe(struct platform_device *pdev) >> } >> platform_set_drvdata(pdev, nocp); >> >> - clk_prepare_enable(nocp->clk); >> + ret = clk_prepare_enable(nocp->clk); >> + if (ret) { >> + dev_err(&pdev->dev, "failed to prepare ppmu clock\n"); >> + return ret; >> + } > > I already replied from the similar patch. Thanks. > >> >> pr_info("exynos-nocp: new NoC Probe device registered: %s\n", >> dev_name(dev)); >> > > I'm missing some point that if there is no clock this driver initializes 'nocp->clk = NULL;' on 217 line. Looks good to me. Acked-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics