From: Thara Gopinath <thara.gopinath@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH 2/2] PM / Domains: Extend generic power domain debugfs.
Date: Mon, 12 Jun 2017 14:51:40 -0400 [thread overview]
Message-ID: <593EE2BC.8080500@linaro.org> (raw)
In-Reply-To: <CAPDyKFpfXqPc2fjHkJVmUP8kmwE4Ec-bcs_Fk=t0F1sSnfWRVQ@mail.gmail.com>
On 06/07/2017 09:51 AM, Ulf Hansson wrote:
> On 26 May 2017 at 01:51, Thara Gopinath <thara.gopinath@linaro.org> wrote:
>> This patch extends the existing generic power domain debugfs.
>> Changes involve the following
>> - Remove the current flat format of displaying generic power domain
>> summary.
>> - Introduce a unique debugfs entry for each generic power domain with the
>> following attributes
>> - current_state - Displays current state of the domain.
>> - devices - Displays the devices associated with this domain.
>> - slaves - Displays the sub power domains.
>
> Maybe "sub_domains" is a better name for the node then?
>
>> - on_time - Displays the time the domain was in on state in ms.
>
> /s/on_time/active_time
>
>> - idle_time - Displays the time the domain was in any of the idle
>> states in ms.
>
> /s/idle_time/total_idle_time
>
>> - idle_states - Displays the various idle states and the time
>> spent in each idle state in ms.
>>
>> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
>
> Besides the nitpicks above, this looks okay to me, however please
> address Geerts comments as well.
Will fix all the above comments and re-send
>
> [...]
>
> Kind regards
> Uffe
>
--
Regards
Thara
prev parent reply other threads:[~2017-06-12 18:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 23:51 [PATCH 0/2] PM / Domains: Expand generic power domain debugfs Thara Gopinath
2017-05-25 23:51 ` [PATCH 1/2] PM / Domains: Add time accounting to various genpd states Thara Gopinath
2017-06-07 13:28 ` Ulf Hansson
2017-06-12 18:51 ` Thara Gopinath
2017-06-13 8:11 ` Ulf Hansson
2017-06-13 12:44 ` Thara Gopinath
2017-06-13 20:17 ` Thara Gopinath
2017-06-14 9:18 ` Ulf Hansson
2017-06-14 21:01 ` Thara Gopinath
2017-05-25 23:51 ` [PATCH 2/2] PM / Domains: Extend generic power domain debugfs Thara Gopinath
2017-05-29 15:12 ` Geert Uytterhoeven
2017-06-07 19:15 ` Thara Gopinath
2017-06-07 13:51 ` Ulf Hansson
2017-06-12 18:51 ` Thara Gopinath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593EE2BC.8080500@linaro.org \
--to=thara.gopinath@linaro.org \
--cc=khilman@baylibre.com \
--cc=linux-pm@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).