From: Hanjun Guo <guohanjun@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Linux PM list <linux-pm@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] ACPI / boot: Correct address space of __acpi_map_table()
Date: Tue, 18 Jul 2017 17:55:16 +0800 [thread overview]
Message-ID: <596DDB04.7080202@huawei.com> (raw)
In-Reply-To: <1500369795.29303.63.camel@linux.intel.com>
On 2017/7/18 17:23, Andy Shevchenko wrote:
> On Tue, 2017-07-18 at 11:03 +0200, Geert Uytterhoeven wrote:
>> Hi Andy,
>>
>> On Mon, Jul 17, 2017 at 12:24 PM, Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>>> Sparse complains about wrong address space used in
>>> __acpi_map_table()
>>> and in __acpi_unmap_table().
>>>
>>> arch/x86/kernel/acpi/boot.c:127:29: warning: incorrect type in
>>> return expression (different address spaces)
>>> arch/x86/kernel/acpi/boot.c:127:29: expected char *
>>> arch/x86/kernel/acpi/boot.c:127:29: got void [noderef] <asn:2>*
>>> arch/x86/kernel/acpi/boot.c:135:23: warning: incorrect type in
>>> argument 1 (different address spaces)
>>> arch/x86/kernel/acpi/boot.c:135:23: expected void [noderef]
>>> <asn:2>*addr
>>> arch/x86/kernel/acpi/boot.c:135:23: got char *map
>>>
>>> Correct address space to be in align of type of returned and passed
>>> parameter.
>>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>> ---
>>> arch/arm64/kernel/acpi.c | 4 ++--
>> Thanks for the update!
>> I can confirm this fixes the arm64 build for me.
> Thanks to you and thanks to kbuild bot to check for ia64!
>
> I will send v3 soon with fixed this part and extended patch 5.
Ah, sorry, there are some delays when I got this email...,
forget about my comments on patch 5.
Thanks
Hanjun
next prev parent reply other threads:[~2017-07-18 9:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 10:23 [PATCH v2 0/5] ACPI / boot: Few amendments Andy Shevchenko
2017-07-17 10:24 ` [PATCH v2 1/5] ACPI / boot: Don't define unused variables Andy Shevchenko
2017-07-17 10:24 ` [PATCH v2 2/5] ACPI / boot: Correct address space of __acpi_map_table() Andy Shevchenko
2017-07-18 9:03 ` Geert Uytterhoeven
2017-07-18 9:23 ` Andy Shevchenko
2017-07-18 9:55 ` Hanjun Guo [this message]
2017-07-17 10:24 ` [PATCH v2 3/5] ACPI / boot: Add number of legacy IRQs to debug output Andy Shevchenko
2017-07-17 10:24 ` [PATCH v2 4/5] ACPI / boot: Not all platform require acpi_reduced_hw_init() Andy Shevchenko
2017-07-17 10:24 ` [PATCH v2 5/5] ACPI / boot: Don't handle SCI on HW reduced platforms Andy Shevchenko
2017-07-17 11:50 ` [PATCH v2 0/5] ACPI / boot: Few amendments Rafael J. Wysocki
2017-07-17 13:30 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2017-07-17 13:29 [Resend, PATCH " Andy Shevchenko
2017-07-17 13:29 ` [PATCH v2 2/5] ACPI / boot: Correct address space of __acpi_map_table() Andy Shevchenko
2017-07-18 9:48 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=596DDB04.7080202@huawei.com \
--to=guohanjun@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).