From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH v2 2/5] ACPI / boot: Correct address space of __acpi_map_table() Date: Tue, 18 Jul 2017 17:55:16 +0800 Message-ID: <596DDB04.7080202@huawei.com> References: <20170717102404.27191-1-andriy.shevchenko@linux.intel.com> <20170717102404.27191-3-andriy.shevchenko@linux.intel.com> <1500369795.29303.63.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1500369795.29303.63.camel@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko , Geert Uytterhoeven Cc: "Rafael J . Wysocki" , Linux PM list , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , the arch/x86 maintainers , "linux-kernel@vger.kernel.org" , ACPI Devel Maling List List-Id: linux-pm@vger.kernel.org On 2017/7/18 17:23, Andy Shevchenko wrote: > On Tue, 2017-07-18 at 11:03 +0200, Geert Uytterhoeven wrote: >> Hi Andy, >> >> On Mon, Jul 17, 2017 at 12:24 PM, Andy Shevchenko >> wrote: >>> Sparse complains about wrong address space used in >>> __acpi_map_table() >>> and in __acpi_unmap_table(). >>> >>> arch/x86/kernel/acpi/boot.c:127:29: warning: incorrect type in >>> return expression (different address spaces) >>> arch/x86/kernel/acpi/boot.c:127:29: expected char * >>> arch/x86/kernel/acpi/boot.c:127:29: got void [noderef] * >>> arch/x86/kernel/acpi/boot.c:135:23: warning: incorrect type in >>> argument 1 (different address spaces) >>> arch/x86/kernel/acpi/boot.c:135:23: expected void [noderef] >>> *addr >>> arch/x86/kernel/acpi/boot.c:135:23: got char *map >>> >>> Correct address space to be in align of type of returned and passed >>> parameter. >>> >>> Signed-off-by: Andy Shevchenko >>> --- >>> arch/arm64/kernel/acpi.c | 4 ++-- >> Thanks for the update! >> I can confirm this fixes the arm64 build for me. > Thanks to you and thanks to kbuild bot to check for ia64! > > I will send v3 soon with fixed this part and extended patch 5. Ah, sorry, there are some delays when I got this email..., forget about my comments on patch 5. Thanks Hanjun