Linux Power Management development
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: myungjoo.ham@samsung.com, kyungmin.park@samsung.com
Cc: rafael.j.wysocki@intel.com, chanwoo@kernel.org,
	inki.dae@samsung.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 8/8] PM / devfreq: exynos-bus: Register cooling device
Date: Thu, 21 Sep 2017 13:57:51 +0900	[thread overview]
Message-ID: <59C346CF.6010105@samsung.com> (raw)
In-Reply-To: <1505954032-3327-9-git-send-email-cw00.choi@samsung.com>

Dear all,

Please ignore this patch. It has some problem.
I'll fix and resend this patch on v2.

Chanwoo Choi
Samsung Electronics

On 2017년 09월 21일 09:33, Chanwoo Choi wrote:
> This patch registers the Exynos Bus-Frequency scaling device
> as a cooling device of thermal management.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/devfreq/Kconfig      |  1 +
>  drivers/devfreq/exynos-bus.c | 11 +++++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 6a172d338f6d..eb8128e08b2c 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -81,6 +81,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
>  	select DEVFREQ_GOV_SIMPLE_ONDEMAND
>  	select DEVFREQ_GOV_PASSIVE
>  	select DEVFREQ_EVENT_EXYNOS_PPMU
> +	select DEVFREQ_THERMAL
>  	select PM_DEVFREQ_EVENT
>  	select PM_OPP
>  	help
> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> index c25658b26598..200ca0d11834 100644
> --- a/drivers/devfreq/exynos-bus.c
> +++ b/drivers/devfreq/exynos-bus.c
> @@ -15,6 +15,7 @@
>  #include <linux/clk.h>
>  #include <linux/devfreq.h>
>  #include <linux/devfreq-event.h>
> +#include <linux/devfreq_cooling.h>
>  #include <linux/device.h>
>  #include <linux/export.h>
>  #include <linux/module.h>
> @@ -41,6 +42,8 @@ struct exynos_bus {
>  	struct clk *clk;
>  	unsigned int voltage_tolerance;
>  	unsigned int ratio;
> +
> +	struct thermal_cooling_device *cdev;
>  };
>  
>  /*
> @@ -468,6 +471,14 @@ static int exynos_bus_probe(struct platform_device *pdev)
>  		goto err;
>  	}
>  
> +	/* Register devfreq cooling device */
> +	bus->cdev = of_devfreq_cooling_register(np, bus->devfreq);
> +	if (IS_ERR(bus->cdev) < 0) {
> +		dev_err(dev, "failed to register cooling device\n");
> +		ret = PTR_ERR(bus->cdev);
> +		goto err;
> +	}
> +
>  	goto out;
>  passive:
>  	/* Initialize the struct profile and governor data for passive device */
> 

  reply	other threads:[~2017-09-21  4:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170921003355epcas1p1d1bbb04ff7a7c46946f62a91883bd6a6@epcas1p1.samsung.com>
2017-09-21  0:33 ` [PATCH v2 0/8] PM / devfreq: Use OPP interface to handle the frequency Chanwoo Choi
2017-09-21  0:33   ` [PATCH v2 1/8] PM / devfreq: Set min/max_freq when adding the devfreq device Chanwoo Choi
2017-09-21  0:33   ` [PATCH v2 2/8] Revert "PM / devfreq: Add show_one macro to delete the duplicate code" Chanwoo Choi
2017-09-21  0:33   ` [PATCH v2 3/8] PM / devfreq: Show the available min/max frequency through sysfs node Chanwoo Choi
2017-09-21  0:33   ` [PATCH v2 4/8] PM / devfreq: Show the all available frequencies Chanwoo Choi
2017-09-21  0:33   ` [PATCH v2 5/8] PM / devfreq: Get the available next frequency on update_devfreq() Chanwoo Choi
2017-09-21  0:33   ` [PATCH v2 6/8] PM / devfreq: Remove unneeded conditional statement Chanwoo Choi
2017-09-21  0:33   ` [PATCH v2 7/8] PM / devfreq: Define the constant governor name Chanwoo Choi
2017-09-21  0:33   ` [PATCH v2 8/8] PM / devfreq: exynos-bus: Register cooling device Chanwoo Choi
2017-09-21  4:57     ` Chanwoo Choi [this message]
2017-09-26  2:31   ` [PATCH v2.1] " Chanwoo Choi
2017-09-27  1:28   ` [PATCH v2 0/8] PM / devfreq: Use OPP interface to handle the frequency Chanwoo Choi
2017-09-27  8:09     ` MyungJoo Ham
2017-09-27  8:15       ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59C346CF.6010105@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=chanwoo@kernel.org \
    --cc=inki.dae@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox