From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F251236AEC for ; Fri, 23 Aug 2024 08:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724402444; cv=none; b=h4s/k+pk/KhLOyNb6DsmgIpcWrnm5t8dHLDS6xWEqPexsh1pjIkgSwGAKcgP4WFtLubxJxU6NJ145PPy6WkxlL144mn4n4fUOoJ4PODo2HLqTLssLgJYazblo9YxyGDJdzXz7wOLYW8UlIJ0UsdHWeRhPXwbGVrRwKFge3jxnyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724402444; c=relaxed/simple; bh=3Lu0q5LE4JQFeJoFtGj8FZCKVCJ+bPdGS586sH9yOco=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XR9YXsh5b/dTL3dH9qaSQSS7voIfG3pnRFe+NG4m+PEwYshPXVKuaVn89cF5wBLWyHl8K6RCIa1/EBJU7J74oUbcNmBlEGVa/VbTc3GA+hwbI+plb63kPErtrByWw+/9WUy+o6zWabl+G+VfEqL0i/wtxJrKwB0pelIEsKBlQa4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=ESSgLe3x; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="ESSgLe3x" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a866cea40c4so211511166b.0 for ; Fri, 23 Aug 2024 01:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724402441; x=1725007241; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fG9KNjBoDmO8zW0C42AiccF/rKtpUpUCjugH/PuwWu0=; b=ESSgLe3xxgMVsQDzDEOkRtpf6Utu7PkuRRdKUktTtrTApdTkyk7/yLAEFm6KtkmsgA QMEJjwGEBpPDrBRT1TeKtkiYPOAbEaM4ayqQYBpgYXwSJRigcTDIemd0PTn6/thWUHAR EsNRBIta/y81CqHbkY2G3LgyNmfwVGV6ovbd871h+cuOIgBGnJuf9aJYQ8h/Yqd7DYSL p1VEuZhVu8AkVE11tE6Jdk/mh1d2EmPT5eKOcbwyqs8LLEhgfgJJl3OPxElYg9xz9nKZ NYSmNXgZwCegojNsxGDL4AmVLcvz/De12W/FH8jIzwdwHINwFsfzaMZ7vrgZuu+xMVXI 5Rsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724402441; x=1725007241; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fG9KNjBoDmO8zW0C42AiccF/rKtpUpUCjugH/PuwWu0=; b=I358687dFRgy/xIzyGVqUVCf79efhtL3tKOLPhycjxNIVmfs9Iub1lOgeLAShvIdoi pBbrCAYCei67zOpiaHTjb//fiuj/IozSIilDybmy4SpEIU5ejPppqC30hzTGuCnzbUjS 9/tyXIvN3o6e1RNaZhMrJsTnq3RCR1EhIgmqHYSAxWzNdBkHRPCNayDDx/XEijH17A6j yehA3cj8vX5ZBsddhL0Rj2QHZDoh4ikhbAQRPZiR5S9CYQofodofn9uTsTrytcFDOVYw zNfJynaQTCg5zrcLh7RkU/wwBj+qPDgAO5EGNVYyvtYwvm+QUn5YPh4vcup1VixPjUFK KjuQ== X-Forwarded-Encrypted: i=1; AJvYcCXhCmMmNzUpv/8tp1yyzUuW6c99gDaFeudBXN/kjmnxL7qlrd9Uy3QWKWHGXdCXxAMUJUpvXYaj3g==@vger.kernel.org X-Gm-Message-State: AOJu0YwONj1bQKHDi9YzZ3A64s09PoWLZ4MdRMfn/0oVAkHn/joU/1Xq jb1JcKXlA/RBKzKN86L4XByvIFHg6+ULNQhkxpXmIYFDU/4wXMLYCAHyr7jpzpE= X-Google-Smtp-Source: AGHT+IELJdt9NWz1Qyq2a+tw+U6RVfRhf7Xtr1odkIop07urXH/CbabXuHZJspnO7+6yMIrduwa9BA== X-Received: by 2002:a17:906:da82:b0:a77:dc70:b35f with SMTP id a640c23a62f3a-a86a54b694dmr101050966b.58.1724402440963; Fri, 23 Aug 2024 01:40:40 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f29004csm229783366b.46.2024.08.23.01.40.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Aug 2024 01:40:40 -0700 (PDT) Message-ID: <59f4d28b-5b9b-427a-baca-739fc03a5cc1@tuxon.dev> Date: Fri, 23 Aug 2024 11:40:37 +0300 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/16] reset: rzg2l-usbphy-ctrl: Add support for RZ/G3S Content-Language: en-US To: Biju Das , "vkoul@kernel.org" , "kishon@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "p.zabel@pengutronix.de" , "geert+renesas@glider.be" , "magnus.damm@gmail.com" , "gregkh@linuxfoundation.org" , "mturquette@baylibre.com" , "sboyd@kernel.org" , Yoshihiro Shimoda , "ulf.hansson@linaro.org" Cc: "linux-phy@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-pm@vger.kernel.org" , Claudiu Beznea References: <20240822152801.602318-1-claudiu.beznea.uj@bp.renesas.com> <20240822152801.602318-9-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Biju, On 22.08.2024 19:59, Biju Das wrote: > Hi Claudiu, > >> -----Original Message----- >> From: Claudiu >> Sent: Thursday, August 22, 2024 4:28 PM >> Subject: [PATCH 08/16] reset: rzg2l-usbphy-ctrl: Add support for RZ/G3S >> >> From: Claudiu Beznea >> >> Add support for RZ/G3S SoC. It needs its own compatible as it uses 2 reset signals and it cannot work >> w/o both of them. To be able to fully validate this on DT schema, too, the RZ/G3S uses it's own >> compatible w/o a fallback (as if the fallback will be used the RZ/G3S will not work anyway). > > Other than reset/ power domain approach for handling USBPWRRDY signal > > Can't USBPWRRDY signal handled in SYSC driver directly? Since SYSC driver init happens at very early boot stage > Check for USBPHY control device availability and handle USBPWRRDY signal there?? In theory, it can be done this way, too. The downside I see at the moment with this approach would be that the USB, PCIe drivers will not be in charge with handling their signals, there will be no direct dependency available b/w SYSC and USB drivers. The HW manual doesn't mention anything about the power consumption of the USB, PCI areas based on the state of the signals from SYSC, so, I don't know if there will be any implication on this if the signals will be just de-asserted from the SYSC driver. Thank you, Claudiu Beznea > Cheers, > Biju > >> >> Signed-off-by: Claudiu Beznea >> --- >> drivers/reset/reset-rzg2l-usbphy-ctrl.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c b/drivers/reset/reset-rzg2l-usbphy-ctrl.c >> index 8b64c12f3bec..08b18d7de7ad 100644 >> --- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c >> +++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c >> @@ -93,6 +93,7 @@ static int rzg2l_usbphy_ctrl_status(struct reset_controller_dev *rcdev, >> >> static const struct of_device_id rzg2l_usbphy_ctrl_match_table[] = { >> { .compatible = "renesas,rzg2l-usbphy-ctrl" }, >> + { .compatible = "renesas,r9a08g045-usbphy-ctrl" }, >> { /* Sentinel */ } >> }; >> MODULE_DEVICE_TABLE(of, rzg2l_usbphy_ctrl_match_table); >> -- >> 2.39.2 >