From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 6/6] arm: dts: exynos4: set opp-suspend for DMC and leftbus Date: Thu, 22 Nov 2018 12:09:31 +0900 Message-ID: <5BF61DEB.5010403@samsung.com> References: <1542823301-23563-1-git-send-email-l.luba@partner.samsung.com> <1542823301-23563-7-git-send-email-l.luba@partner.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: In-reply-to: <1542823301-23563-7-git-send-email-l.luba@partner.samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Lukasz Luba , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Cc: tjakobi@math.uni-bielefeld.de, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz, gregkh@linuxfoundation.org, keescook@chromium.org, anton@enomsg.org, ccross@android.com, tony.luck@intel.com, robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org, krzk@kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com List-Id: linux-pm@vger.kernel.org Hi, On 2018년 11월 22일 03:01, Lukasz Luba wrote: > Mark the state for devfreq device while entring suspend/resume process. > > The patch draws on Tobias Jakobi's work posted ~2 years ago, who tried to > solve issue with devfreq device's frequency during suspend/resume. > During the discussion on LKML some corner cases and comments appeared > related to the design. This patch address them keeping in mind suggestions > from Chanwoo Choi. > > Suggested-by: Tobias Jakobi > Suggested-by: Chanwoo Choi > Signed-off-by: Lukasz Luba > --- > arch/arm/boot/dts/exynos4210.dtsi | 2 ++ > arch/arm/boot/dts/exynos4412.dtsi | 2 ++ > 2 files changed, 4 insertions(+) Looks good to me. Reviewed-by: Chanwoo Choi > > diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi > index b6091c2..4429b72 100644 > --- a/arch/arm/boot/dts/exynos4210.dtsi > +++ b/arch/arm/boot/dts/exynos4210.dtsi > @@ -298,6 +298,7 @@ > opp-400000000 { > opp-hz = /bits/ 64 <400000000>; > opp-microvolt = <1150000>; > + opp-suspend; > }; > }; > > @@ -367,6 +368,7 @@ > }; > opp-200000000 { > opp-hz = /bits/ 64 <200000000>; > + opp-suspend; > }; > }; > }; > diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi > index 51f72f0..908c0c4 100644 > --- a/arch/arm/boot/dts/exynos4412.dtsi > +++ b/arch/arm/boot/dts/exynos4412.dtsi > @@ -432,6 +432,7 @@ > opp-400000000 { > opp-hz = /bits/ 64 <400000000>; > opp-microvolt = <1050000>; > + opp-suspend; > }; > }; > > @@ -520,6 +521,7 @@ > opp-200000000 { > opp-hz = /bits/ 64 <200000000>; > opp-microvolt = <1000000>; > + opp-suspend; > }; > }; > > -- Best Regards, Chanwoo Choi Samsung Electronics