From: zhong jiang <zhongjiang@huawei.com>
To: zhong jiang <zhongjiang@huawei.com>
Cc: <sre@kernel.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static
Date: Tue, 29 Oct 2019 00:16:37 +0800 [thread overview]
Message-ID: <5DB71465.6050203@huawei.com> (raw)
In-Reply-To: <1571672407-58950-1-git-send-email-zhongjiang@huawei.com>
ping.
On 2019/10/21 23:40, zhong jiang wrote:
> The GCC complains the following case when compiling kernel.
>
> drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/power/supply/cpcap-charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
> index 40d96b8..c0d452e 100644
> --- a/drivers/power/supply/cpcap-charger.c
> +++ b/drivers/power/supply/cpcap-charger.c
> @@ -560,7 +560,7 @@ static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
> dev_dbg(ddata->dev, "state: %s\n", status);
> }
>
> -int cpcap_charger_voltage_to_regval(int voltage)
> +static int cpcap_charger_voltage_to_regval(int voltage)
> {
> int offset;
>
next prev parent reply other threads:[~2019-10-28 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 15:40 [PATCH] power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static zhong jiang
2019-10-21 17:04 ` Sebastian Reichel
2019-10-28 16:16 ` zhong jiang [this message]
2019-10-28 21:56 ` Sebastian Reichel
2019-10-29 3:09 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DB71465.6050203@huawei.com \
--to=zhongjiang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).