From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 05/11] Doc: DT: thermal: new irq-mode for trip point Date: Mon, 12 Nov 2018 13:09:09 -0600 Message-ID: <5bea0ecd.1c69fb81.d5613.1c9e@mx.google.com> References: <1541610593-28542-1-git-send-email-l.luba@partner.samsung.com> <1541610593-28542-6-git-send-email-l.luba@partner.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1541610593-28542-6-git-send-email-l.luba@partner.samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Lukasz Luba Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, edubezval@gmail.com, b.zolnierkie@samsung.com, rui.zhang@intel.com, linux-arm-kernel@lists.infradead.org List-Id: linux-pm@vger.kernel.org On Wed, Nov 07, 2018 at 06:09:47PM +0100, Lukasz Luba wrote: > Thermal trip point gets new flag in DT: irq-mode. > Trip point may have a new explicit flag which indicate > IRQ support when the temperature is met (so the thermal framework > deos not need to set polling for it). > It is useful for 'passive' cooling trip point, > which now will not register for polling the temperature. > > Update documentation about irq-mode for trip points. This patch should come before you use it. > > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Daniel Lezcano > Cc: Rob Herring > Cc: Mark Rutland > Cc: devicetree@vger.kernel.org > Signed-off-by: Lukasz Luba > --- > Documentation/devicetree/bindings/thermal/thermal.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt > index ca14ba9..bee21e3 100644 > --- a/Documentation/devicetree/bindings/thermal/thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/thermal.txt > @@ -90,6 +90,10 @@ Required properties: > "critical": Hardware not reliable. > Type: string > > +- irq-mode: A flag indicating that trip rises irq, so there is no > + Type: bool need of polling in thermal framework. > + Size: one cell Should be optional, right? > + > * Cooling device maps > > The cooling device maps node is a node to describe how cooling devices > @@ -256,16 +260,19 @@ thermal-zones { > temperature = <90000>; /* millicelsius */ > hysteresis = <2000>; /* millicelsius */ > type = "active"; > + irq-mode; > }; > cpu_alert1: cpu-alert1 { > temperature = <100000>; /* millicelsius */ > hysteresis = <2000>; /* millicelsius */ > type = "passive"; > + irq-mode; > }; > cpu_crit: cpu-crit { > temperature = <125000>; /* millicelsius */ > hysteresis = <2000>; /* millicelsius */ > type = "critical"; > + irq-mode; > }; > }; > > -- > 2.7.4 >