From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7FCF1DFD0; Sun, 7 Jul 2024 13:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720357362; cv=none; b=r+Q69pu/5ng4EowKGSfNzORLe1SjkOIts5KbnOMRf6fQxpse2wTuwrNwvxEaFANIS7Dz8sv4T7LH8fpDhz9oR++BNevBcGxioKqngy0XqJ1zfRqWvf4uDyRQ9+Vve38wwlqeJWi+mSAKoYgXp/hx2RDGNzZq+22fYalFNve3NHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720357362; c=relaxed/simple; bh=AISQHqqAR/mblpWZAWlUUZweLSIxHkE/HcK1mnvfczs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Vn/jTni8i7eja+Cl+u15WP/UZXASVCDzcvHeeK77gQWvXRlUY+qE4KOBah8VWQAL/gwf9eTMwKz5Av0ZBWNQXn20nj7ksnv1EDFkwVMUMlMZEsSpm63uh9rraTWKWZUC6oYS8AO5m3Tvx9RK9DMTjJ7/4vlemkTZQWab9xlzM7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KVhuVdfQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KVhuVdfQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C70FC3277B; Sun, 7 Jul 2024 13:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720357362; bh=AISQHqqAR/mblpWZAWlUUZweLSIxHkE/HcK1mnvfczs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KVhuVdfQQ/cHa02J18+0WmRI6kb36VBBxqnC4l+9Jes6cWMW5qPvMUJnyMDy8zYJH L32bAxXujDXI/Esf4TKLOv3++8v507YLLYzN0FMPlkyywlsWqlO3rIS4AYIQvQWlVt aJNAMrBqDep7zGEAnU4Jn9jSIsogC53k/jxgkp/lMdKsbx+lwetrP4+FDjPPF67npA dicrw8QBHXL3ly+zcJMr41ctiE2cCByDIIkb9aZwUATCDsrwu5KpCoit9SvYccG+U/ fnRo0ULwTXB9V3d6ydGkCGZnN5atx0ueyJPTUtk8G7YIxrlcXuMvuv5nz8gqyr9K1Z O/TnJdav0Efag== Message-ID: <5c1658a1-3290-48c3-a39a-9e5c837bdb70@kernel.org> Date: Sun, 7 Jul 2024 15:02:37 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] power: sequenceing: Add power sequence for Amlogic WCN chips To: yang.li@amlogic.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20240705-pwrseq-v1-0-31829b47fc72@amlogic.com> <20240705-pwrseq-v1-2-31829b47fc72@amlogic.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240705-pwrseq-v1-2-31829b47fc72@amlogic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/07/2024 13:13, Yang Li via B4 Relay wrote: > From: Yang Li > > Add power sequence for Bluetooth and Wi-Fi respectively, including chip_en > pull-up and bt_en pull-up, and generation of the 32.768 clock. > > Signed-off-by: Yang Li > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +struct pwrseq_aml_wcn_ctx { > + struct pwrseq_device *pwrseq; > + int bt_enable_gpio; Why? It's never used... or you use wrong API. Confusing code. > + int chip_enable_gpio; > + struct clk *lpo_clk; > + unsigned int pwr_count; > +}; > + > +static DEFINE_MUTEX(pwrseq_lock); Why this is not part of structure above? > + ... > + > +static int pwrseq_aml_wcn_match(struct pwrseq_device *pwrseq, > + struct device *dev) > +{ > + struct device_node *dev_node = dev->of_node; > + > + if (!of_property_present(dev_node, "amlogic,wcn-pwrseq")) You cannot have undocumented properties, sorry, that's a NAK. > + return 0; > + > + return 1; > +} > + > +static int pwrseq_aml_wcn_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct pwrseq_aml_wcn_ctx *ctx; > + struct pwrseq_config config; > + > + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + > + ctx->bt_enable_gpio = of_get_named_gpio(dev->of_node, > + "amlogic,bt-enable-gpios", 0); > + if (!gpio_is_valid(ctx->bt_enable_gpio)) > + return dev_err_probe(dev, ctx->bt_enable_gpio, > + "Failed to get the bt enable GPIO"); > + > + ctx->chip_enable_gpio = of_get_named_gpio(dev->of_node, > + "amlogic,chip-enable-gpios", 0); > + if (!gpio_is_valid(ctx->chip_enable_gpio)) > + return dev_err_probe(dev, ctx->bt_enable_gpio, > + "Failed to get the chip enable GPIO"); > + > + ctx->lpo_clk = devm_clk_get_optional(dev, NULL); Clock is not optional, according to you binding. > + if (IS_ERR(ctx->lpo_clk)) > + return dev_err_probe(dev, PTR_ERR(ctx->lpo_clk), > + "Failed to get the clock source"); > + > + memset(&config, 0, sizeof(config)); Just initialize it on the stack with 0. Best regards, Krzysztof