Re: [PATCH v4 5/5] power: supply: Add new Intel Dollar Cove TI battery driver

[Hans de Goede <hansg@kernel.org>]

Hi Sebastian,

On 6-Sep-25 1:59 AM, Sebastian Reichel wrote:
> Hi,
> 
> On Sun, Aug 31, 2025 at 02:29:41PM +0200, Hans de Goede wrote:
>> [...]
>> +	/*
>> +	 * Note cannot use devm_iio_channel_get because ACPI systems lack
>> +	 * the device<->channel maps which iio_channel_get will uses when passed
>> +	 * a non NULL device pointer.
>> +	 */
>> +	chip->vbat_channel = devm_iio_channel_get(dev, "VBAT");
>> +	if (IS_ERR(chip->vbat_channel)) {
>> +		dev_dbg(dev, "devm_iio_channel_get() ret %ld\n", PTR_ERR(chip->vbat_channel));
>> +		return dev_err_probe(dev, -EPROBE_DEFER, "Waiting for VBAT IIO channel\n");
>> +	}
>> [...]
> 
> The comment confuses me. What is it supposed to tell me? Is it a
> leftover from early development stages?

Yes this is a copy and paste from a comment in
drivers/power/supply/axp288_fuel_gauge.c where the comment at least
is accurate in that over there the non devm iio_channel_get() is used.

Clearly it is possible to use the devm variant though as shown in
this new driver. I'll submit a patch dropping the bogus comment
right away.

And I'll also make a note to see if we can move axp288_fuel_gauge.c
over to using the devm_ variant too.

> Anyways, I merged the whole
> series as it looks good to me.

Thank you.

> But I think this comment should be
> fixed in a follow-up patch :)

Follow-up patch is on its way.

Regards,

Hans