public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: David Arcari <darcari@redhat.com>
To: Len Brown <lenb@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/power turbostat: Allow execution to continue after perf_l2_init() failure
Date: Fri, 10 Apr 2026 12:06:43 -0400	[thread overview]
Message-ID: <5ec684ae-b778-40ba-8a10-dfbf274da7dd@redhat.com> (raw)
In-Reply-To: <CAJvTdKmepvPzWDM+6s9YERe27H6pSKbDb62yfpTSs57hWsEmRg@mail.gmail.com>


Hi Len,

On 4/10/26 8:59 AM, Len Brown wrote:
> Thank you for the patch, David, it is helpful.
> 
> I agree that turbostat should do its best to run properly when the
> underlying kernel
> doesn't have full support, and you found a configuration that I missed.
> 
> I'd like to understand how/why your kernel perf support is failing on alder lake
> to be sure turbostat is coping the best it can.
> 
> If you can identify an upstream kernel version that fails this way,
> that would be great.

I'm using a Fedora kernel:

vmlinuz-7.0.0-0.rc4.260320g0e4f8f1a3d08.40.eln155.x86_64

And turbostat is:

# turbostat -v
turbostat version 2026.02.14 - Len Brown <lenb@kernel.org>

> 
> You can poke with "perf stat" as well, but this will depend on what
> .json counter list is compiled into
> your version of perf.
> 
> probably a first sanity check would be if these commands for the LLC
> and the L2 work:
> 
> sudo perf stat -e cache-misses sleep 1
> sudo perf stat -e L2_REQUEST.ALL sleep 1

# sudo perf stat -e cache-misses sleep 1

  Performance counter stats for 'sleep 1':

    <not supported>      cpu_atom/cache-misses/ 

             11,212      cpu_core/cache-misses/ 


        1.001044852 seconds time elapsed

        0.000793000 seconds user
        0.000000000 seconds sys

# sudo perf stat -e L2_REQUEST.ALL sleep 1

  Performance counter stats for 'sleep 1':

    <not supported>      cpu_atom/L2_REQUEST.ALL/ 

             98,451      cpu_core/L2_REQUEST.ALL/ 


        1.001072723 seconds time elapsed

        0.000761000 seconds user
        0.000000000 seconds sys

> 
> Also, with your L2 patch applied, does turbostat still successfully
> show the LLC stats?
> 
# ./turbostat --quiet -s Core,CPU,LLCMRPS,LLC%hit -n 1
Core	CPU	LLCMRPS	LLC%hit
-	-	1	91.33
0	0	0	93.48
0	1	0	86.86
1	2	0	90.68
1	3	0	98.61
2	4	0	98.59
2	5	0	98.79
3	6	0	90.86
3	7	0	97.64
4	8	0	97.52
4	9	0	99.33
5	10	0	85.54
5	11	0	90.85

Let me know if you need something else.

Thanks,
-DA

> thanks,
> Len Brown, Intel Open Source Technology Center
> 


  reply	other threads:[~2026-04-10 16:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 14:03 [PATCH] tools/power turbostat: Allow execution to continue after perf_l2_init() failure David Arcari
2026-04-09 19:13 ` Len Brown
2026-04-10 12:59   ` Len Brown
2026-04-10 16:06     ` David Arcari [this message]
2026-04-10 18:09       ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ec684ae-b778-40ba-8a10-dfbf274da7dd@redhat.com \
    --to=darcari@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox