From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Rob Herring <robh@kernel.org>
Cc: <will@kernel.org>, <arnd@arndb.de>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_kaushalk@quicinc.com>,
<peng.fan@nxp.com>, <kernel@quicinc.com>,
<catalin.marinas@arm.com>, <rafal@milecki.pl>,
<krzysztof.kozlowski+dt@linaro.org>, <nfraprado@collabora.com>,
<quic_shashim@quicinc.com>, <robh+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <quic_tingweiz@quicinc.com>,
<quic_aiquny@quicinc.com>, <linux-pm@vger.kernel.org>,
<quic_tsoni@quicinc.com>, <geert+renesas@glider.be>,
<andersson@kernel.org>, <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <agross@kernel.org>,
<quic_tdas@quicinc.com>, <djakov@kernel.org>,
<konrad.dybcio@linaro.org>
Subject: Re: [PATCH 1/3] dt-bindings: interconnect: Add Qualcomm SM4450
Date: Mon, 11 Sep 2023 18:15:44 +0800 [thread overview]
Message-ID: <5f172a8f-ecd7-44b0-9b02-48eb13d40497@quicinc.com> (raw)
In-Reply-To: <375df554-e661-42ad-8a6f-f862aa05b654@quicinc.com>
在 9/8/2023 4:25 PM, Tengfei Fan 写道:
>
>
> 在 9/8/2023 3:42 PM, Rob Herring 写道:
>>
>> On Fri, 08 Sep 2023 14:44:25 +0800, Tengfei Fan wrote:
>>> The Qualcomm SM4450 SoC has several bus fabrics that could be controlled
>>> and tuned dynamically according to the bandwidth demand.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>> .../interconnect/qcom,sm4450-rpmh.yaml | 133 ++++++++++++++
>>> .../dt-bindings/interconnect/qcom,sm4450.h | 163 ++++++++++++++++++
>>> 2 files changed, 296 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/interconnect/qcom,sm4450-rpmh.yaml
>>> create mode 100644 include/dt-bindings/interconnect/qcom,sm4450.h
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Documentation/devicetree/bindings/interconnect/qcom,sm4450-rpmh.example.dts:18:18: fatal error: dt-bindings/clock/qcom,gcc-sm4450.h: No such file or directory
>> 18 | #include <dt-bindings/clock/qcom,gcc-sm4450.h>
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> compilation terminated.
>> make[2]: *** [scripts/Makefile.lib:419:
>> Documentation/devicetree/bindings/interconnect/qcom,sm4450-rpmh.example.dtb] Error 1
>> make[2]: *** Waiting for unfinished jobs....
>> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500:
>> dt_binding_check] Error 2
>> make: *** [Makefile:234: __sub-make] Error 2
>>
>> doc reference errors (make refcheckdocs):
>>
>> See
>> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230908064427.26999-2-quic_tengfan@quicinc.com
>>
>> The base for the series is generally the latest rc1. A different
>> dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your
>> schema.
>>
> Thanks review this patch, will setup new env for verify again.
>
this error is due to have dependence with:
https://lore.kernel.org/linux-arm-msm/20230824173410.550126-1-quic_ajipan@quicinc.com/,
will add this link to coverletter.
--
Thx and BRs,
Tengfei Fan
next prev parent reply other threads:[~2023-09-11 21:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 6:44 [PATCH 0/3] interconnect: qcom: Add SM4450 interconnect driver Tengfei Fan
2023-09-08 6:44 ` [PATCH 1/3] dt-bindings: interconnect: Add Qualcomm SM4450 Tengfei Fan
2023-09-08 7:42 ` Rob Herring
2023-09-08 8:25 ` Tengfei Fan
2023-09-11 10:15 ` Tengfei Fan [this message]
2023-09-11 11:43 ` Krzysztof Kozlowski
2023-09-11 11:48 ` Krzysztof Kozlowski
2023-09-08 6:44 ` [PATCH 2/3] interconnect: qcom: Add SM4450 interconnect provider driver Tengfei Fan
2023-09-08 8:16 ` Konrad Dybcio
2023-09-08 8:26 ` Tengfei Fan
2023-09-08 6:44 ` [PATCH 3/3] arm64: defconfig: enable interconnect for SM4450 Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f172a8f-ecd7-44b0-9b02-48eb13d40497@quicinc.com \
--to=quic_tengfan@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=geert+renesas@glider.be \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=peng.fan@nxp.com \
--cc=quic_aiquny@quicinc.com \
--cc=quic_kaushalk@quicinc.com \
--cc=quic_shashim@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox