Re: [PATCH v3 0/5 RESEND] thermal: qcom-spmi-temp-alarm: Add support for new TEMP_ALARM subtypes

Anjelique Melendez
2025-04-08T21:51:41Z

On 3/20/2025 1:24 PM, Anjelique Melendez wrote:
> Add support in the qcom-spmi-temp-alarm driver for the new PMIC
> TEMP_ALARM peripheral subtypes: GEN2 rev 2 and LITE. The GEN2 rev 2
> subtype provides greater flexibility in temperature threshold
> specification by using an independent register value to configure
> each of the three thresholds. The LITE subtype utilizes a simplified
> set of control registers to configure two thresholds: warning and
> shutdown. While at it refactor the qcom-spmi-temp-alarm driver to limit
> code reuse and if/else statements when deciphering between TEMP_ALARM
> peripheral subtypes.
>
> Also add support to avoid a potential issue on certain versions of
> the TEMP_ALARM GEN2 subtype when automatic stage 2 partial shutdown
> is disabled.
>
> This patch series is a continuation of older series from 7/2024
> (https://lore.kernel.org/all/20240729231259.2122976-1-quic_amelende@quicinc.com/)
> but current series has been reworked to address the change in thermal framework to
> update .set_trip_temp() callback function variables
> (https://lore.kernel.org/all/8392906.T7Z3S40VBb@rjwysocki.net/)
>
> Changes since v2:
> - Updated function name to include "gen1" in patch 2/5
> - Added Dmitry's reviewed-by tag in patch 2/5
> - link: https://lore.kernel.org/all/20250225192429.2328092-1-anjelique.melendez@oss.qualcomm.com/
> Changes since v1:
> - Remove unnecessary moving of code
> - Added new v2 patch 3/5 add a preparation patch to v1 patch 2/5
> - Updated temp alarm data function names to be consistently named
> - link: https://lore.kernel.org/all/20250213210403.3396392-1-anjelique.melendez@oss.qualcomm.com/
>
> Anjelique Melendez (4):
> thermal: qcom-spmi-temp-alarm: Add temp alarm data struct based on HW
> subtype
> thermal: qcom-spmi-temp-alarm: Prepare to support additional Temp
> Alarm subtypes
> thermal: qcom-spmi-temp-alarm: add support for GEN2 rev 2 PMIC
> peripherals
> thermal: qcom-spmi-temp-alarm: add support for LITE PMIC peripherals
>
> David Collins (1):
> thermal: qcom-spmi-temp-alarm: enable stage 2 shutdown when required
>
> drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 515 ++++++++++++++++++--
> 1 file changed, 464 insertions(+), 51 deletions(-)
>
Hi Amit and Thara,
Can you take a look at changes when you have a chance.

Thanks,
Anjelique