Re: [PATCH v3 4/6] platform/x86:intel/pmc: Show substate requirement for S0ix blockers

[Russell Haley <yumpusamongus@gmail.com>]

On 8/15/25 5:46 PM, Xi Pardee wrote:
> Add support to read and show S0ix blocker substate requirements.
> Starting from Panther Lake, substate requirement data is provided
> based on S0ix blockers instead of all low power mode requirements.
> For platforms that support this new feature, add support to display
> substate requirements based on S0ix blockers.
> 
> Change the "substate_requirements" attribute of Intel PMC Core
> driver to show the substate requirements for each S0ix blocker
> and the corresponding S0ix blocker value.
> 
> Signed-off-by: Xi Pardee <xi.pardee@linux.intel.com>
> ---
>  drivers/platform/x86/intel/pmc/arl.c  |   4 +
>  drivers/platform/x86/intel/pmc/core.c | 126 ++++++++++++++++++++++++--
>  drivers/platform/x86/intel/pmc/core.h |  14 +++
>  drivers/platform/x86/intel/pmc/lnl.c  |   2 +
>  drivers/platform/x86/intel/pmc/mtl.c  |   2 +
>  5 files changed, 138 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/pmc/arl.c b/drivers/platform/x86/intel/pmc/arl.c
> index 9d66d65e75779..17ad87b392abe 100644
> --- a/drivers/platform/x86/intel/pmc/arl.c
> +++ b/drivers/platform/x86/intel/pmc/arl.c
> @@ -725,9 +725,11 @@ struct pmc_dev_info arl_pmc_dev = {
>  	.dmu_guid = ARL_PMT_DMU_GUID,
>  	.regmap_list = arl_pmc_info_list,
>  	.map = &arl_socs_reg_map,
> +	.sub_req_show = &pmc_core_substate_req_regs_fops,
>  	.suspend = cnl_suspend,
>  	.resume = arl_resume,
>  	.init = arl_core_init,
> +	.sub_req = pmc_core_pmt_get_lpm_req,
>  };
>  
>  struct pmc_dev_info arl_h_pmc_dev = {
> @@ -735,7 +737,9 @@ struct pmc_dev_info arl_h_pmc_dev = {
>  	.dmu_guid = ARL_PMT_DMU_GUID,
>  	.regmap_list = arl_pmc_info_list,
>  	.map = &mtl_socm_reg_map,
> +	.sub_req_show = &pmc_core_substate_req_regs_fops,
>  	.suspend = cnl_suspend,
>  	.resume = arl_h_resume,
>  	.init = arl_h_core_init,
> +	.sub_req = pmc_core_pmt_get_lpm_req,
>  };

The cover letter and commit messages say Panther Lake, but I see a bunch
of "arl" here. Is this just confusing file and struct names, or is my
Arrow Lake 265K getting idle-blocker-cause debug info? If so it should
probably be mentioned in the changelog.

Same question about patch 5.

- Russell Haley