Linux Power Management development
 help / color / mirror / Atom feed
From: Jeremy Linton <jeremy.linton@arm.com>
To: Thorsten Leemhuis <linux@leemhuis.info>, linux-pm@vger.kernel.org
Cc: trenn@suse.com, shuah@kernel.org, jwyatt@redhat.com,
	jkacur@redhat.com, kaushlendra.kumar@intel.com,
	sashal@kernel.org, fj5851bi@fujitsu.com, rui.zhang@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] cpupower: Add generic CPPC performance display
Date: Mon, 20 Jul 2026 13:33:16 -0500	[thread overview]
Message-ID: <611fb9db-6263-4e53-a2cf-9ec35ae8ef17@arm.com> (raw)
In-Reply-To: <b87c77da-d207-4b9d-a36a-5cdfd03eacde@leemhuis.info>

Hi,

On 7/18/26 1:12 AM, Thorsten Leemhuis wrote:
> On 7/10/26 00:13, Jeremy Linton wrote:
>> Arm64 machines, and possibly others, use the standard ACPI defined CPPC
>> infrastructure. cpupower has CPPC support, but it's largely written
>> around the intricacies of AMD processors, using platform MSRs to avoid
>> shortcomings in the specification.

Patch to fix it.

https://lkml.org/lkml/2026/7/20/2191

>>
>> [...]
>> +#include <stdio.h>
>> +#include <errno.h>
>> +#include <stdlib.h>
>> +#include <string.h>
>> +#include <math.h>
>> +
>> +#include "helpers/helpers.h"
>> +#include "cpufreq.h"
>> +#include "acpi_cppc.h"
>> +
>> +#define cppc_to_frequency(perf) (roundf(slope * (perf) + intercept))
> FYI, this patch showed up in -next yesterday and I suspect it caused
> this build error for me on x86_64:
> 
> """  CC       cpupower
> /usr/bin/ld.bfd: /tmp/ccjOeWLF.ltrans0.ltrans.o: in function
> `get_perf_cap.isra.0':
> /builddir/build/BUILD/kernel-7.2.0-build/kernel-next-20260717/linux-7.2.0-0.0.next.20260717.330.vanilla.fc44.x86_64/tools/power/cpupower/utils/helpers/cppc.c:39:(.text+0x45cc):
> undefined reference to `roundf'
> /usr/bin/ld.bfd:
> /tmp/ccjOeWLF.ltrans0.ltrans.o:/builddir/build/BUILD/kernel-7.2.0-build/kernel-next-20260717/linux-7.2.0-0.0.next.20260717.330.vanilla.fc44.x86_64/tools/power/cpupower/utils/helpers/cppc.c:49:(.text+0x46a2):
> undefined reference to `roundf'
> collect2: error: ld returned 1 exit status
> make: *** [Makefile:238: cpupower] Error 1
> """
>> [...]
> 
> Full log:
> https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-44-x86_64/10739303-next-next-all/builder-live.log.gz
> 
> Ciao, Thorsten


  parent reply	other threads:[~2026-07-20 18:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09 22:13 [PATCH 0/3] cpupower: Improve arm64 frequency and CPPC reporting Jeremy Linton
2026-07-09 22:13 ` [PATCH 1/3] cpupower: Add generic CPPC performance display Jeremy Linton
2026-07-18  6:12   ` Thorsten Leemhuis
2026-07-20 17:56     ` Jeremy Linton
2026-07-20 18:33     ` Jeremy Linton [this message]
2026-07-20 23:23       ` Shuah Khan
2026-07-09 22:13 ` [PATCH 2/3] cpupower: Build and call CPPC information on non-AMD processors Jeremy Linton
2026-07-09 22:13 ` [PATCH 3/3] cpupower: Print kernel and hardware frequency information Jeremy Linton
2026-07-16 23:39 ` [PATCH 0/3] cpupower: Improve arm64 frequency and CPPC reporting Shuah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=611fb9db-6263-4e53-a2cf-9ec35ae8ef17@arm.com \
    --to=jeremy.linton@arm.com \
    --cc=fj5851bi@fujitsu.com \
    --cc=jkacur@redhat.com \
    --cc=jwyatt@redhat.com \
    --cc=kaushlendra.kumar@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=rui.zhang@intel.com \
    --cc=sashal@kernel.org \
    --cc=shuah@kernel.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox