From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 406DF1BC40 for ; Thu, 22 Aug 2024 03:25:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724297159; cv=none; b=cOSCCAnpIVedDbn8Q8lya8nQEbBL6vBLpP9BtGlP7X0ngl6F0dxBrC8HfBtLHbkmAnA4syZK7+uCQ3aBFx7jpcIsUujiE0D86611XZvhsNKIRTVljMaRs5VpD4lmuA4uiHA0N5EpJADZKL+u2OSUf9Jyrf0ku3mgCGLEc/dwas0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724297159; c=relaxed/simple; bh=hyKDjj4CJqAx5VGdmx/yJM4qAEXZNm60VYDVRGi2I2c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Iby9cZd79PIOKJuIGtEtwySA0bMTZnnG3RM4IkLIqmv3XrOsldTYBRVFFWDyno6SzZqGJxTc/8qofk4W9jSb1WrWJ8Pir5HxXNQn5p5skefr8A1iWgwW3TRxq2mTNqEwDU1dsdNdsP9aVpq/kIOsJccSVy3L6/qfcaSyoPZitC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IBMPYR+w; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IBMPYR+w" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3db145c8010so202247b6e.3 for ; Wed, 21 Aug 2024 20:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1724297156; x=1724901956; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hyKDjj4CJqAx5VGdmx/yJM4qAEXZNm60VYDVRGi2I2c=; b=IBMPYR+wJwzUarBLB+S2ksEPZksgHmm5GPO92pPsInWm4So2siDUYql0NsFrt0Y1X1 jfS6GCvxEYYdd1B4xji1hvhNhWUZ+FYzEnQey5aGDZT5vTKLKqXb+ES+uMbPAeKHkUOt yGb3U2C4Bs8MIYBlwNxNcMe/vSlP4H47isL2Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724297156; x=1724901956; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hyKDjj4CJqAx5VGdmx/yJM4qAEXZNm60VYDVRGi2I2c=; b=iZDtJwnfWc4ZpuFjYPwDwfDaabxXp7DABK5NdTZr4C63XJL/41p+G8NuHBJa4dn4UF WcddwxGfl38NGiPrLrOOfvBRSPQ/A+jPd/bF05dCt9esYxudqTT/plx8TYq7AEnjB8Eq c5N9Cl25C1C2jKe05Dwe1cGVMR7VTrBxVniNq/KZj4424GKv64LGbjaun1Lopfwx2PTj R5EVFCKuTA89srfPR2AjoM4odvq+i7GTyzXPImzsbdCidwiwuXEFRW+AjM+4I4R4Gvma lpaX1PX9UJ/fY97luI6tuds3D6gsmYM8rRUOwHffeketd7Dszcg16o3UkUM3iJw1oIKJ ksEA== X-Gm-Message-State: AOJu0YzUj4+TU6W50Hwyk5lTjYD3vhl823j3zw4hQWU1iUKGM+jp//34 9CZL9N8tJcpLLn+O6XC1xSNXWqH/UAlWt104m3/UBErKIjX9A4FPksy4+ZP8k3A= X-Google-Smtp-Source: AGHT+IEIuEGCRRmhieJjBWHd6gs4O35qd+zZB2nQ4Ts+alXoKgwtX529u4Ots4uOQLOwdY/3cR1apQ== X-Received: by 2002:a05:6808:1910:b0:3d6:5791:a378 with SMTP id 5614622812f47-3de194fee4bmr5282599b6e.17.1724297156263; Wed, 21 Aug 2024 20:25:56 -0700 (PDT) Received: from [172.20.0.208] ([218.188.70.188]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7cd9ac994a3sm346023a12.16.2024.08.21.20.25.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 20:25:55 -0700 (PDT) Message-ID: <61b180e2-6c88-4047-bad9-4d712bd5072d@linuxfoundation.org> Date: Wed, 21 Aug 2024 21:25:52 -0600 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2][RFC] Add SWIG Bindings to libcpupower To: "John B. Wyatt IV" Cc: linux-pm@vger.kernel.org, Thomas Renninger , Shuah Khan , Linus Torvalds , linux-kernel@vger.kernel.org, John Kacur , Tomas Glozar , Arnaldo Melo , "John B. Wyatt IV" , Shuah Khan , Greg Kroah-Hartman References: <20240724221122.54601-1-jwyatt@redhat.com> <1f5c24b6-f3ee-4863-8b7a-49344a550206@linuxfoundation.org> <2024080405-roundish-casket-2474@gregkh> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/21/24 01:08, Shuah Khan wrote: > On 8/20/24 00:40, John B. Wyatt IV wrote: >> I wanted to follow up on this since I am close to sending out the v2 of >> this patchset. >> Here is more complete response after my quick response. >> 3 points I wanted to raise: >> >> 1) Does everyone understand, is okay with the SWIG license, and wants to >> proceed with me sending in a more complete version of this as a candidate for >> upstreaming? >> Yes - send patch series without RFC tag. >> 2) About maintainership: if I am to be the maintainer of this, how would >> myself and John Kacur be listed? As a CPU POWER MONITORING SUBSYSTEM >> maintainer, a separate category below it called CPU POWER MONITORING SUBSYSTEM >> PYTHON BINDINGS maintainer, or is not needed to be listed at this time? >> Let's not add a new category at this time. You can add yourself and John Kacur be Reviewers under CPU POWER MONITORING SUBSYSTEM for now. We can revisit as we go forward. >> A quick search for bindings shows what I believe to be all of them for device >> tree. This may establish a new precedent. >> I don't fully understand the above. Will this patch series include device tree changes? I didn't get that from the RFC. >> If I was to be added, I assume it would be a separate commit in the v2 >> submission? >> >> 3) I had to comment out powercap_set_enabled >> >> SWIG reported this symbol not being found despite being in powercap.h. I did a >> quick search and was not able to find it's implementation in powercap.c. The >> get equivalent powercap_get_enabled is in powercap.c. Wanted to check on this >> just in case it is a bug or part of future functionality. I am assuming the >> latter; I would send it v2 with that declaration commented out with a note >> explaining it for users if there is no objection. Good find. It is missing functionality. For now you can define it in powercap.c to simply return 0 with a TODO thanks, -- Shuah