From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77DC0C433EF for ; Thu, 23 Jun 2022 01:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230245AbiFWBKo (ORCPT ); Wed, 22 Jun 2022 21:10:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230101AbiFWBKo (ORCPT ); Wed, 22 Jun 2022 21:10:44 -0400 Received: from ZXSHCAS2.zhaoxin.com (ZXSHCAS2.zhaoxin.com [210.0.225.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FFF230F68; Wed, 22 Jun 2022 18:10:41 -0700 (PDT) Received: from zxbjmbx1.zhaoxin.com (10.29.252.163) by ZXSHCAS2.zhaoxin.com (10.28.252.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 23 Jun 2022 09:10:38 +0800 Received: from [10.32.64.1] (10.32.64.1) by zxbjmbx1.zhaoxin.com (10.29.252.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 23 Jun 2022 09:10:36 +0800 Subject: Re: [PATCH] x86/cstate: Add Zhaoxin ACPI Cx FFH MWAIT support To: "Rafael J. Wysocki" CC: Len Brown , Pavel Machek , "Thomas Gleixner" , Ingo Molnar , "Borislav Petkov" , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , Linux PM , Linux Kernel Mailing List , , , , , ACPI Devel Maling List References: From: Tony W Wang-oc Message-ID: <61d5a117-c0d8-8752-5d70-b383530aef86@zhaoxin.com> Date: Thu, 23 Jun 2022 09:10:37 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.32.64.1] X-ClientProxiedBy: ZXSHCAS2.zhaoxin.com (10.28.252.162) To zxbjmbx1.zhaoxin.com (10.29.252.163) Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 22/6/2022 21:38, Rafael J. Wysocki wrote: > Please CC linux-acpi@vger.kernel.org on ACPI-related changes (added now). Ok. > > On Wed, Jun 22, 2022 at 5:29 AM Tony W Wang-oc wrote: >> >> Recent Zhaoxin CPUs support X86_FEATURE_MWAIT that implies the >> MONITOR/MWAIT instructions can be used for ACPI Cx state. The BIOS >> declares Cx state in _CST object to use FFH on Zhaoxin systems. So >> let function ffh_cstate_init() support Zhaoxin too. >> >> Signed-off-by: Tony W Wang-oc >> --- >> arch/x86/kernel/acpi/cstate.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c >> index 7945eae..d4185e1 100644 >> --- a/arch/x86/kernel/acpi/cstate.c >> +++ b/arch/x86/kernel/acpi/cstate.c >> @@ -213,7 +213,9 @@ static int __init ffh_cstate_init(void) >> >> if (c->x86_vendor != X86_VENDOR_INTEL && >> c->x86_vendor != X86_VENDOR_AMD && >> - c->x86_vendor != X86_VENDOR_HYGON) >> + c->x86_vendor != X86_VENDOR_HYGON && >> + c->x86_vendor != X86_VENDOR_CENTAUR && >> + c->x86_vendor != X86_VENDOR_ZHAOXIN) > > Centaur is not mentioned in the changelog and it should be. Will add Centaur in the changelog. Thanks a lot. > >> return -1; >> >> cpu_cstate_entry = alloc_percpu(struct cstate_entry); >> -- > . > -- Sincerely TonyWWang-oc