From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A047C63777 for ; Tue, 17 Nov 2020 20:25:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E28832220B for ; Tue, 17 Nov 2020 20:25:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vJmRBtG5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726734AbgKQUYn (ORCPT ); Tue, 17 Nov 2020 15:24:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbgKQUYm (ORCPT ); Tue, 17 Nov 2020 15:24:42 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B162C0617A6 for ; Tue, 17 Nov 2020 12:24:41 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id h2so4714827wmm.0 for ; Tue, 17 Nov 2020 12:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=uFgfIH0qmM2n17BDKaKrcq4LBODq5k4QOoezQr/yK4Q=; b=vJmRBtG5Y4PKYnYzUVh08Dqvpcn/A+iQlTefDkvBSaY/otn7EDLv0dIIj3ExHDw5TK DJhn0fmMls/fo3Ji04nfqYpC6VAJIrSLNF1zevXLRp+Mqs0gIX3k1ay250TfmDCvRB05 +OFGUIWqHJivI8tvxU/N+BXqMuYAmxnqziUr/zXER+4xntRWIfLL4Km6b98Y3TvV59GU eCTzi5TRJcLVXq0HVatVqEhWOZJHM4JeETvtJEpY6E3ejXSsyHLJMnRl9ptM2VzXUngX y3G3hvj79F6xHWtKigSGV3YGOmPS8F7zoviWPz5zt2J2EGLFG8jcg5kblMW5AUYS5yq7 YUCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uFgfIH0qmM2n17BDKaKrcq4LBODq5k4QOoezQr/yK4Q=; b=Uy0OuU45uQpKJz4jDkCuimLVhB8feTNsP5L2fc1qWe+jnGtTZnMgMykvKHoqAtyoAC oW7Q2u4IJhqRrb80bLPeJ5YN/1f9uz7nWQOESieamhaf043E9j5IBsjtw3BgMQ6SObBS 0nefCqC/9E+p4Eue+ZrMvb5FFSf6b//pN/FNzuwXOaxXqVc3k8LWoTbrvHNge1prz9sL TP9THLMBNi+6Eh9CRkQrM6zG7S3hUHuHwSVO0KYj4/C5xZE1LjfRx01rE2g8BSiplVJr 8g3MZ1r+MIFDoaf6y78G+l9+kt+F2eF0I3+lNs1xN3YV+cka159xirbR1VO3PHBmlELG I5wQ== X-Gm-Message-State: AOAM531g0haY6q92PuVUCQpyHs+FBiLtO6nx+HVCEiSViv60pe8k/mDC wh4nmcw0WCwN6kFxK0zjR2hv1w== X-Google-Smtp-Source: ABdhPJwcGefASVcjHgpreQsZnk+jCTM8HC7WIOgyOmgrLL/gpuFF2XEZQHvIGAjfywFtjECtmDfZ7g== X-Received: by 2002:a1c:2643:: with SMTP id m64mr903602wmm.28.1605644679580; Tue, 17 Nov 2020 12:24:39 -0800 (PST) Received: from MacBook-Pro.local ([212.45.64.13]) by smtp.googlemail.com with ESMTPSA id m18sm27902466wru.37.2020.11.17.12.24.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2020 12:24:38 -0800 (PST) Subject: Re: [PATCH v9 01/17] memory: tegra30: Support interconnect framework To: Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski Cc: linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20201115212922.4390-1-digetx@gmail.com> <20201115212922.4390-2-digetx@gmail.com> From: Georgi Djakov Message-ID: <61e777d9-b730-02c6-cedf-cf0aa1a50fb8@linaro.org> Date: Tue, 17 Nov 2020 22:24:37 +0200 MIME-Version: 1.0 In-Reply-To: <20201115212922.4390-2-digetx@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Dmitry, Thank you working on this! On 15.11.20 23:29, Dmitry Osipenko wrote: > Now Internal and External memory controllers are memory interconnection > providers. This allows us to use interconnect API for tuning of memory > configuration. EMC driver now supports OPPs and DVFS. MC driver now > supports tuning of memory arbitration latency, which needs to be done > for ISO memory clients, like a Display client for example. > > Tested-by: Peter Geis > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/Kconfig | 1 + > drivers/memory/tegra/tegra30-emc.c | 349 +++++++++++++++++++++++++++-- > drivers/memory/tegra/tegra30.c | 173 +++++++++++++- > 3 files changed, 501 insertions(+), 22 deletions(-) > [..]> diff --git a/drivers/memory/tegra/tegra30.c b/drivers/memory/tegra/tegra30.c > index d0314f29608d..ea849003014b 100644 > --- a/drivers/memory/tegra/tegra30.c > +++ b/drivers/memory/tegra/tegra30.c [..] > + > +static int tegra30_mc_icc_set(struct icc_node *src, struct icc_node *dst) > +{ > + struct tegra_mc *mc = icc_provider_to_tegra_mc(src->provider); > + const struct tegra_mc_client *client = &mc->soc->clients[src->id]; > + u64 peak_bandwidth = icc_units_to_bps(src->peak_bw); > + > + /* > + * Skip pre-initialization that is done by icc_node_add(), which sets > + * bandwidth to maximum for all clients before drivers are loaded. > + * > + * This doesn't make sense for us because we don't have drivers for all > + * clients and it's okay to keep configuration left from bootloader > + * during boot, at least for today. > + */ > + if (src == dst) > + return 0; Nit: The "proper" way to express this should be to implement the .get_bw() callback to return zero as initial average/peak bandwidth. I'm wondering if this will work here? The rest looks good to me! Thanks, Georgi