From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [PATCH 2/8] arm64: dts: exynos: Add GSCL power domain to Exynos 5433 SoC Date: Fri, 27 Jan 2017 11:33:36 +0100 Message-ID: <62a55088-ff3d-dc4b-b0f0-9810d88801c4@samsung.com> References: <1485345342-3273-1-git-send-email-m.szyprowski@samsung.com> <1485345342-3273-3-git-send-email-m.szyprowski@samsung.com> <20170127074617.ez6wxeu5vyz6lm4x@kozik-lap> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:35093 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933582AbdA0LFu (ORCPT ); Fri, 27 Jan 2017 06:05:50 -0500 In-reply-to: <20170127074617.ez6wxeu5vyz6lm4x@kozik-lap> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Krzysztof Kozlowski Cc: linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Chanwoo Choi , Inki Dae Hi Krzysztof, On 2017-01-27 08:46, Krzysztof Kozlowski wrote: > On Wed, Jan 25, 2017 at 12:55:36PM +0100, Marek Szyprowski wrote: >> This patch adds support for GSCL power domain to Exynos 5433 SoCs, which >> contains following devices: a clock controller, three GSCL video scalers and >> their SYSMMUs. >> >> Signed-off-by: Marek Szyprowski >> --- >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> index 16072c1c3ed3..74c767d756ac 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> @@ -425,6 +425,7 @@ >> clocks = <&xxti>, >> <&cmu_top CLK_ACLK_GSCL_111>, >> <&cmu_top CLK_ACLK_GSCL_333>; >> + power-domains = <&pd_gscl>; >> }; >> >> cmu_apollo: clock-controller@11900000 { >> @@ -525,6 +526,12 @@ >> <&cmu_top CLK_ACLK_CAM1_552>; >> }; >> >> + pd_gscl: gscl-power-domain@105c4000 { > The name of node: just "power-domain". This should be generic class of > device (following ePAPR). > > The same applies to other patches. Well, this makes the debugging much harder, but I will change it to generic names. Also existing Exynos dtsi should be fixed in this area (Exynos4 still use such more descriptive names). I will check how hard is to add real domain names directly to the Exynos power domain driver then. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland