From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73C793A5E65; Tue, 31 Mar 2026 11:19:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774955986; cv=none; b=eOTTlLnDWvkgOPfO94I/L/rT0D91oqH3bUwtGL6Y24BN8O3rDz7S2+/JIrYa07xsXsroCrk35dIddrotDECnBRlLMx7Acny4rjH74rRC2+PYe6+X6b8d/0ErUSM0uFkZEhL2EPUkV6jvF3ccJzjEDMbYxgiBMFcGAoryvCH1lyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774955986; c=relaxed/simple; bh=ZnDW1YU1OZ07ojqBOp0PfWuBUEGetEGfTQ0tqVxhf08=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kdZcKvpXXmQgtI98hLep9aaPie3jC23M9mGAPt8ZIgdXW3Ih579lqtbs9zQ4OCSe36RG/3sqQMtM7I4KVRucz9fZeiBggMQKPSkQILrftbolEKUs8jzOhUWClLbK2b1q+XqerRTVXH4gqeIXnKW99blsT1+JNnDXUOS5wv5Vu+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vE5VV2zk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vE5VV2zk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7B53C19423; Tue, 31 Mar 2026 11:19:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774955986; bh=ZnDW1YU1OZ07ojqBOp0PfWuBUEGetEGfTQ0tqVxhf08=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=vE5VV2zkAusrFlj2hvEIJoBuq/gLYl2nqmKS0MZRbJmA+O+Nx25OOkQ9RKbxblOfV S5B/DSMhS8z6cypn4dRP84kKmXv4q+amO6JOgCOayp2W+lPuwk05KI6ILUJcc3oHdB 743GQtkSzShpdp0VuUxeF0qpP6Fd7KEDwlTRuXsM3/bRsCmX8EcauBv5NJbDQ0V1Jf kageaPFFqHwlZ8lJpBKBNS193gvvEYO+hZysBtRJ29fnuJZq8BsfKN7fazzbhzb5bU t2QncRVEo/6f7HpAlg53wv05nOfAmzaZCncChMvo6CIsAoA/C8ADo4C/pwW2g5tVrd PKw7n3gwEOg7Q== Message-ID: <62bebe94-f22c-4a99-b558-fd530fe37c7e@kernel.org> Date: Tue, 31 Mar 2026 12:19:46 +0100 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/5] media: iris: scale MMCX power domain on SM8250 To: Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Jonathan Marek , Ulf Hansson , "Rafael J. Wysocki" , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Stanimir Varbanov , Abhinav Kumar , Hans Verkuil , Stefan Schmidt , Konrad Dybcio , Bryan O'Donoghue , Dikshita Agarwal Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab References: <20260209-iris-venus-fix-sm8250-v5-0-0a22365d3585@oss.qualcomm.com> <9DynOSHOdFz_RbNlLUuDUtQ3mZs5zW5pHr0UtUtXeU5s_43qnkK-at1mGkKJaT6LET06dWAf06BTG02GdukDRQ==@protonmail.internalid> <20260209-iris-venus-fix-sm8250-v5-2-0a22365d3585@oss.qualcomm.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20260209-iris-venus-fix-sm8250-v5-2-0a22365d3585@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 09/02/2026 01:32, Dmitry Baryshkov wrote: > On SM8250 most of the video clocks are powered by the MMCX domain, while > the PLL is powered on by the MX domain. Extend the driver to support > scaling both power domains, while keeping compatibility with the > existing DTs, which define only the MX domain. > > Fixes: 79865252acb6 ("media: iris: enable video driver probe of SM8250 SoC") > Reviewed-by: Dikshita Agarwal > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_platform_gen1.c | 2 +- > drivers/media/platform/qcom/iris/iris_probe.c | 7 +++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > index df8e6bf9430e..aa71f7f53ee3 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > @@ -281,7 +281,7 @@ static const struct bw_info sm8250_bw_table_dec[] = { > > static const char * const sm8250_pmdomain_table[] = { "venus", "vcodec0" }; > > -static const char * const sm8250_opp_pd_table[] = { "mx" }; > +static const char * const sm8250_opp_pd_table[] = { "mx", "mmcx" }; > > static const struct platform_clk_data sm8250_clk_table[] = { > {IRIS_AXI_CLK, "iface" }, > diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c > index 7b612ad37e4f..74ec81e3d622 100644 > --- a/drivers/media/platform/qcom/iris/iris_probe.c > +++ b/drivers/media/platform/qcom/iris/iris_probe.c > @@ -64,6 +64,13 @@ static int iris_init_power_domains(struct iris_core *core) > return ret; > > ret = devm_pm_domain_attach_list(core->dev, &iris_opp_pd_data, &core->opp_pmdomain_tbl); > + /* backwards compatibility for incomplete ABI SM8250 */ > + if (ret == -ENODEV && > + of_device_is_compatible(core->dev->of_node, "qcom,sm8250-venus")) { > + iris_opp_pd_data.num_pd_names--; > + ret = devm_pm_domain_attach_list(core->dev, &iris_opp_pd_data, ci is choking on this. => drivers/media/platform/qcom/venus/pm_helpers.c: In function ‘vcodec_domains_get’: drivers/media/platform/qcom/venus/pm_helpers.c:910:41: error: decrement of read-only member ‘num_pd_names’ 910 | opp_pd_data.num_pd_names--; | ^~ => include/linux/pm_domain.h struct dev_pm_domain_attach_data { const char * const *pd_names; const u32 num_pd_names; const u32 pd_flags; }; => struct dev_pm_domain_attach_data opp_pd_data = { .pd_names = res->opp_pmdomain, .num_pd_names = res->opp_pmdomain_num, .pd_flags = PD_FLAG_DEV_LINK_ON | PD_FLAG_REQUIRED_OPP, }; --- bod