From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33782C54EB4 for ; Sun, 22 Jan 2023 14:21:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229960AbjAVOVo (ORCPT ); Sun, 22 Jan 2023 09:21:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229814AbjAVOVn (ORCPT ); Sun, 22 Jan 2023 09:21:43 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B5BD14EAF; Sun, 22 Jan 2023 06:21:42 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id z5so8635546wrt.6; Sun, 22 Jan 2023 06:21:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=sx8TcFi7ahlbn2SOE1QPhy8oz/wraKFlbImNAj4SudA=; b=V6NEeA+GNXA2gLBEOUV/HgzSGDGzodN+lXOr2hnzEPpbNED/q/HdzS82UCCiMiqOBp KDgQMjjd7+A4XGDm1LpHnwct+rsgSJhjEk1kOvcocdj/ySu7jhfklGmoQvQaSDvbtLqm EXEgzurJlws7du1bC6XUzz2JYHGLmQ2xKZdGW4IOpbO16S7lAaLOKpGRb5dRHakYX/uh UDS6I6I07eIPcJxiqRCPe+PQwGLDfRo/mgiUzjtV70jbWZEBDuNTOkDkjgaD5afPIXWT JDA1uttyBqlDpKijBsPzh8gCJuw/Ydm9jxHH8lijiJ/Bbcc7x13iUm0cxejfzDq/VupP 0dHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sx8TcFi7ahlbn2SOE1QPhy8oz/wraKFlbImNAj4SudA=; b=MLFy7xTI7kAHpAAs4Op8hM9A2rMxKvxfhz1gV9M2Sn9flE8DdtsKQxAuaVwRthdT/G Wao4Zh72OiPZblB3WWRI5BmDpeQqSDhNC38avjXBULNLtQ6TBb8JMZ5Vc8ET7RSSY3b7 Gy4/38lFpYhAeBc3uUvtlhXceT/EVbwpM/3HU5K4c5ofWPH9LDThrJQPfb7bAeVlg1Ty dHllK4edbTB4s4rD7TxYxyK9D4lmDIalhG54pjVcULaKmO0ScNEUcezqW2SnIvAfisPI xtoIsPiys8J9kXCtMqYlZTyn3EL1kcT5qsyNZUlfUN99U9QPEbAH/S0qWaSIPv7yUsIj jAcg== X-Gm-Message-State: AFqh2kqXp3ZKwV0agCqfn/3IJ0NiO0FwDouv46lJ3+55PvuP4WUMbXCO xiz5+YWvD6Orw+e7ODr3Bko= X-Google-Smtp-Source: AMrXdXs1vCV4gm5Bhka0+ci14P+N2HjRmntz6aRoSuuYWL6N8yVFGUWiXMJCgur6ArNb3oRTSxJqpw== X-Received: by 2002:a5d:6e8b:0:b0:2bd:d9b5:8191 with SMTP id k11-20020a5d6e8b000000b002bdd9b58191mr18974484wrz.61.1674397300772; Sun, 22 Jan 2023 06:21:40 -0800 (PST) Received: from Ansuel-xps. (93-34-89-61.ip49.fastwebnet.it. [93.34.89.61]) by smtp.gmail.com with ESMTPSA id k9-20020a5d6d49000000b002bc8130cca7sm32381502wri.23.2023.01.22.06.21.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Jan 2023 06:21:40 -0800 (PST) Message-ID: <63cd4674.5d0a0220.57633.fef5@mx.google.com> X-Google-Original-Message-ID: Date: Sun, 22 Jan 2023 15:21:38 +0100 From: Christian Marangi To: Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ilia Lin , "Rafael J. Wysocki" , Viresh Kumar , Rob Herring , Krzysztof Kozlowski , Nishanth Menon , Stephen Boyd , Yassine Oudjana , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: opp: opp-v2-kryo-cpu: add opp-microvolt nvmem based References: <20230121000146.7809-1-ansuelsmth@gmail.com> <20230121000146.7809-2-ansuelsmth@gmail.com> <4b58dcf1-df8a-048f-ba6f-ea170479751b@linaro.org> <63cd44e6.050a0220.ed90.635a@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Sun, Jan 22, 2023 at 03:17:54PM +0100, Krzysztof Kozlowski wrote: > On 22/01/2023 15:15, Christian Marangi wrote: > > On Sun, Jan 22, 2023 at 03:00:22PM +0100, Krzysztof Kozlowski wrote: > >> On 21/01/2023 01:01, Christian Marangi wrote: > >>> The operating-points-v2-kryo-cpu driver supports defining multiple > >>> opp-microvolt based on the blown efuses in the soc. It consist of 3 > >>> values that are parsed: speedbin, psv and version. They are all > >>> appended to the opp-microvolt name and selected by the nvmem driver and > >>> loaded dynamically at runtime. > >>> > >>> Example: > >>> > >>> opp-microvolt-speed0-pvs0-v0 = <1050000 997500 1102500>; > >>> opp-microvolt-speed0-pvs1-v0 = <975000 926250 1023750>; > >>> opp-microvolt-speed0-pvs2-v0 = <925000 878750 971250>; > >>> opp-microvolt-speed0-pvs3-v0 = <850000 807500 892500>; > >>> > >>> Add support for this and reject these special binding if we don't have a > >>> nvmem-cell to read data from. > >>> > >>> Signed-off-by: Christian Marangi > >>> --- > >>> .../devicetree/bindings/opp/opp-v2-kryo-cpu.yaml | 16 ++++++++++++++++ > >>> 1 file changed, 16 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml b/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml > >>> index b4947b326773..cea932339faf 100644 > >>> --- a/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml > >>> +++ b/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml > >>> @@ -61,6 +61,17 @@ patternProperties: > >>> > >>> required-opps: true > >>> > >>> + patternProperties: > >>> + '^opp-microvolt-speed[0-9]-pvs[0-9]-v[0-9]$': > >> > >> This does not end with correct unit suffix. Should be > >> opp-speed-.....-microvolt > >> > > > > I think I didn't understand this? > > > > From opp-v2-base and from what we are using downstream, the named > > opp-micrvolt works correctly. > > > > (speed[0-9]-pvs[0-9]-v[0-9] is the entire name of the named > > opp-microvolt- binding) > > > > This is the reference I always used for the pattern. [1] > > Here the pattern used by the driver. [2] > > > > [1] https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/opp/opp-v2-base.yaml#L209 > > [2] https://elixir.bootlin.com/linux/latest/source/drivers/cpufreq/qcom-cpufreq-nvmem.c#L238 > > Are you documenting existing property or adding new? Commit msg suggests > you add new property, so what do you reference here? How is it related? > It should have been added from the start when the schema was submitted but I get what you mean with the other question. > > > >>> + description: | > >>> + Assign a microvolt value to the opp hz based on the efuses value from > >>> + speedbin, pvs and vers > >> > >> Where is the DTS change? > > > > You mean an additional example that use this additional binding? This > > may be difficult to add since the current example in this schema is a > > root one and I can't put multiple root example. > > No, I mean, you DTS using it. We do not want empty (unused) bindings... > Ok, will drop this and make it part of the ipq8064 opp series that will use this binding. -- Ansuel