* [PATCH] cpuidle: Fix reference count on CPU node
@ 2024-09-17 21:13 Miquel Sabaté Solà
2024-10-01 20:13 ` Miquel Sabaté Solà
2024-10-26 18:22 ` Dmitry Baryshkov
0 siblings, 2 replies; 6+ messages in thread
From: Miquel Sabaté Solà @ 2024-09-17 21:13 UTC (permalink / raw)
To: rafael
Cc: daniel.lezcano, linux-arm-msm, linux-pm, linux-kernel,
Miquel Sabaté Solà
For the qcom-spm driver, an early return was not calling the proper
of_node_put call for a previously acquired device node.
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
---
drivers/cpuidle/cpuidle-qcom-spm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/cpuidle/cpuidle-qcom-spm.c b/drivers/cpuidle/cpuidle-qcom-spm.c
index 1fc9968eae19..d3608f47d02b 100644
--- a/drivers/cpuidle/cpuidle-qcom-spm.c
+++ b/drivers/cpuidle/cpuidle-qcom-spm.c
@@ -96,8 +96,10 @@ static int spm_cpuidle_register(struct device *cpuidle_dev, int cpu)
return -ENODEV;
saw_node = of_parse_phandle(cpu_node, "qcom,saw", 0);
- if (!saw_node)
+ if (!saw_node) {
+ of_node_put(cpu_node);
return -ENODEV;
+ }
pdev = of_find_device_by_node(saw_node);
of_node_put(saw_node);
--
2.46.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] cpuidle: Fix reference count on CPU node
2024-09-17 21:13 [PATCH] cpuidle: Fix reference count on CPU node Miquel Sabaté Solà
@ 2024-10-01 20:13 ` Miquel Sabaté Solà
2024-10-22 13:05 ` Miquel Sabaté Solà
2024-10-26 18:22 ` Dmitry Baryshkov
1 sibling, 1 reply; 6+ messages in thread
From: Miquel Sabaté Solà @ 2024-10-01 20:13 UTC (permalink / raw)
To: rafael; +Cc: daniel.lezcano, linux-arm-msm, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
On dt., de set. 17 2024, Miquel Sabaté Solà wrote:
> For the qcom-spm driver, an early return was not calling the proper
> of_node_put call for a previously acquired device node.
>
> Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
> ---
> drivers/cpuidle/cpuidle-qcom-spm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/cpuidle-qcom-spm.c b/drivers/cpuidle/cpuidle-qcom-spm.c
> index 1fc9968eae19..d3608f47d02b 100644
> --- a/drivers/cpuidle/cpuidle-qcom-spm.c
> +++ b/drivers/cpuidle/cpuidle-qcom-spm.c
> @@ -96,8 +96,10 @@ static int spm_cpuidle_register(struct device *cpuidle_dev, int cpu)
> return -ENODEV;
>
> saw_node = of_parse_phandle(cpu_node, "qcom,saw", 0);
> - if (!saw_node)
> + if (!saw_node) {
> + of_node_put(cpu_node);
> return -ENODEV;
> + }
>
> pdev = of_find_device_by_node(saw_node);
> of_node_put(saw_node);
Gently ping for a fix in the same spirit as [1].
Could you take a look whenever you have some time?
Thanks!
Miquel
[1] https://lore.kernel.org/all/20240917134246.584026-1-mikisabate@gmail.com/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpuidle: Fix reference count on CPU node
2024-10-01 20:13 ` Miquel Sabaté Solà
@ 2024-10-22 13:05 ` Miquel Sabaté Solà
2024-11-14 6:32 ` Miquel Sabaté Solà
0 siblings, 1 reply; 6+ messages in thread
From: Miquel Sabaté Solà @ 2024-10-22 13:05 UTC (permalink / raw)
To: rafael; +Cc: daniel.lezcano, linux-arm-msm, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]
On dt., d’oct. 01 2024, Miquel Sabaté Solà wrote:
> On dt., de set. 17 2024, Miquel Sabaté Solà wrote:
>
>> For the qcom-spm driver, an early return was not calling the proper
>> of_node_put call for a previously acquired device node.
>>
>> Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
>> ---
>> drivers/cpuidle/cpuidle-qcom-spm.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpuidle/cpuidle-qcom-spm.c b/drivers/cpuidle/cpuidle-qcom-spm.c
>> index 1fc9968eae19..d3608f47d02b 100644
>> --- a/drivers/cpuidle/cpuidle-qcom-spm.c
>> +++ b/drivers/cpuidle/cpuidle-qcom-spm.c
>> @@ -96,8 +96,10 @@ static int spm_cpuidle_register(struct device *cpuidle_dev, int cpu)
>> return -ENODEV;
>>
>> saw_node = of_parse_phandle(cpu_node, "qcom,saw", 0);
>> - if (!saw_node)
>> + if (!saw_node) {
>> + of_node_put(cpu_node);
>> return -ENODEV;
>> + }
>>
>> pdev = of_find_device_by_node(saw_node);
>> of_node_put(saw_node);
>
> Gently ping for a fix in the same spirit as [1].
>
> Could you take a look whenever you have some time?
>
> Thanks!
> Miquel
>
> [1] https://lore.kernel.org/all/20240917134246.584026-1-mikisabate@gmail.com/
Gently ping. Could someone take a look at this fix?
Thanks,
Miquel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpuidle: Fix reference count on CPU node
2024-09-17 21:13 [PATCH] cpuidle: Fix reference count on CPU node Miquel Sabaté Solà
2024-10-01 20:13 ` Miquel Sabaté Solà
@ 2024-10-26 18:22 ` Dmitry Baryshkov
1 sibling, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2024-10-26 18:22 UTC (permalink / raw)
To: Miquel Sabaté Solà
Cc: rafael, daniel.lezcano, linux-arm-msm, linux-pm, linux-kernel
On Tue, Sep 17, 2024 at 11:13:25PM +0200, Miquel Sabaté Solà wrote:
> For the qcom-spm driver, an early return was not calling the proper
> of_node_put call for a previously acquired device node.
>
> Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
> ---
> drivers/cpuidle/cpuidle-qcom-spm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpuidle: Fix reference count on CPU node
2024-10-22 13:05 ` Miquel Sabaté Solà
@ 2024-11-14 6:32 ` Miquel Sabaté Solà
2024-12-03 6:27 ` Miquel Sabaté Solà
0 siblings, 1 reply; 6+ messages in thread
From: Miquel Sabaté Solà @ 2024-11-14 6:32 UTC (permalink / raw)
To: rafael; +Cc: daniel.lezcano, linux-arm-msm, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]
On dt., d’oct. 22 2024, Miquel Sabaté Solà wrote:
> On dt., d’oct. 01 2024, Miquel Sabaté Solà wrote:
>
>> On dt., de set. 17 2024, Miquel Sabaté Solà wrote:
>>
>>> For the qcom-spm driver, an early return was not calling the proper
>>> of_node_put call for a previously acquired device node.
>>>
>>> Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
>>> ---
>>> drivers/cpuidle/cpuidle-qcom-spm.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/cpuidle/cpuidle-qcom-spm.c b/drivers/cpuidle/cpuidle-qcom-spm.c
>>> index 1fc9968eae19..d3608f47d02b 100644
>>> --- a/drivers/cpuidle/cpuidle-qcom-spm.c
>>> +++ b/drivers/cpuidle/cpuidle-qcom-spm.c
>>> @@ -96,8 +96,10 @@ static int spm_cpuidle_register(struct device *cpuidle_dev, int cpu)
>>> return -ENODEV;
>>>
>>> saw_node = of_parse_phandle(cpu_node, "qcom,saw", 0);
>>> - if (!saw_node)
>>> + if (!saw_node) {
>>> + of_node_put(cpu_node);
>>> return -ENODEV;
>>> + }
>>>
>>> pdev = of_find_device_by_node(saw_node);
>>> of_node_put(saw_node);
>>
>> Gently ping for a fix in the same spirit as [1].
>>
>> Could you take a look whenever you have some time?
>>
>> Thanks!
>> Miquel
>>
>> [1] https://lore.kernel.org/all/20240917134246.584026-1-mikisabate@gmail.com/
>
> Gently ping. Could someone take a look at this fix?
>
> Thanks,
> Miquel
Hello,
This is most probably too late for 6.12, but might this be included for
6.13?
Could you take a look?
Thanks,
Miquel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpuidle: Fix reference count on CPU node
2024-11-14 6:32 ` Miquel Sabaté Solà
@ 2024-12-03 6:27 ` Miquel Sabaté Solà
0 siblings, 0 replies; 6+ messages in thread
From: Miquel Sabaté Solà @ 2024-12-03 6:27 UTC (permalink / raw)
To: rafael; +Cc: daniel.lezcano, linux-arm-msm, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1753 bytes --]
On dj., de nov. 14 2024, Miquel Sabaté Solà wrote:
> On dt., d’oct. 22 2024, Miquel Sabaté Solà wrote:
>
>> On dt., d’oct. 01 2024, Miquel Sabaté Solà wrote:
>>
>>> On dt., de set. 17 2024, Miquel Sabaté Solà wrote:
>>>
>>>> For the qcom-spm driver, an early return was not calling the proper
>>>> of_node_put call for a previously acquired device node.
>>>>
>>>> Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
>>>> ---
>>>> drivers/cpuidle/cpuidle-qcom-spm.c | 4 +++-
>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/cpuidle/cpuidle-qcom-spm.c b/drivers/cpuidle/cpuidle-qcom-spm.c
>>>> index 1fc9968eae19..d3608f47d02b 100644
>>>> --- a/drivers/cpuidle/cpuidle-qcom-spm.c
>>>> +++ b/drivers/cpuidle/cpuidle-qcom-spm.c
>>>> @@ -96,8 +96,10 @@ static int spm_cpuidle_register(struct device *cpuidle_dev, int cpu)
>>>> return -ENODEV;
>>>>
>>>> saw_node = of_parse_phandle(cpu_node, "qcom,saw", 0);
>>>> - if (!saw_node)
>>>> + if (!saw_node) {
>>>> + of_node_put(cpu_node);
>>>> return -ENODEV;
>>>> + }
>>>>
>>>> pdev = of_find_device_by_node(saw_node);
>>>> of_node_put(saw_node);
>>>
>>> Gently ping for a fix in the same spirit as [1].
>>>
>>> Could you take a look whenever you have some time?
>>>
>>> Thanks!
>>> Miquel
>>>
>>> [1] https://lore.kernel.org/all/20240917134246.584026-1-mikisabate@gmail.com/
>>
>> Gently ping. Could someone take a look at this fix?
>>
>> Thanks,
>> Miquel
>
> Hello,
>
> This is most probably too late for 6.12, but might this be included for
> 6.13?
>
> Could you take a look?
>
> Thanks,
> Miquel
Hello,
Gently ping. Could you please take a look at this fix?
Thanks,
Miquel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-12-03 6:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-17 21:13 [PATCH] cpuidle: Fix reference count on CPU node Miquel Sabaté Solà
2024-10-01 20:13 ` Miquel Sabaté Solà
2024-10-22 13:05 ` Miquel Sabaté Solà
2024-11-14 6:32 ` Miquel Sabaté Solà
2024-12-03 6:27 ` Miquel Sabaté Solà
2024-10-26 18:22 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).