From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Nishanth Menon <nm@ti.com>
Cc: linux-pm@vger.kernel.org,
Rajagopal Venkat <rajagopal.venkat@linaro.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [for-next PATCH 1/2] PM / devfreq: more documentation warning fixes
Date: Fri, 26 Oct 2012 02:05:04 +0200 [thread overview]
Message-ID: <6833848.UlMixi1sUD@vostro.rjw.lan> (raw)
In-Reply-To: <1351206614-23993-2-git-send-email-nm@ti.com>
On Thursday, October 25, 2012 06:10:13 PM Nishanth Menon wrote:
> Commit 34b53237e9ceb141e13e846baed2a282461f4a01
> (PM / devfreq: Add suspend and resume apis)
> in Rafael's pm-devfreq-next branch on
> git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
>
> Patchworks: https://patchwork.kernel.org/patch/1545791/
>
> Warning(drivers/devfreq/devfreq.c:436): No description found for parameter 'devfreq'
> Warning(drivers/devfreq/devfreq.c:450): No description found for parameter 'devfreq'
>
> Yet again, a missing ':' causes the kernel-doc to cry
>
> Since it is not merged to upstream, I suggest squashing it
>
> Cc: Rajagopal Venkat <rajagopal.venkat@linaro.org>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
I fixed up the original patch in a slightly different way.
Thanks,
Rafael
> ---
> drivers/devfreq/devfreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 32e9b48..cdc3e2d 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -430,7 +430,7 @@ EXPORT_SYMBOL(devfreq_remove_device);
>
> /**
> * devfreq_suspend_device() - Suspend devfreq of a device.
> - * @devfreq the devfreq instance to be suspended
> + * @devfreq: the devfreq instance to be suspended
> */
> int devfreq_suspend_device(struct devfreq *devfreq)
> {
> @@ -444,7 +444,7 @@ EXPORT_SYMBOL(devfreq_suspend_device);
>
> /**
> * devfreq_resume_device() - Resume devfreq of a device.
> - * @devfreq the devfreq instance to be resumed
> + * @devfreq: the devfreq instance to be resumed
> */
> int devfreq_resume_device(struct devfreq *devfreq)
> {
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2012-10-26 0:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 23:10 [for-next PATCH 0/2] PM / devfreq: more documentation fixes Nishanth Menon
2012-10-25 23:10 ` [for-next PATCH 1/2] PM / devfreq: more documentation warning fixes Nishanth Menon
2012-10-26 0:05 ` Rafael J. Wysocki [this message]
2012-10-25 23:10 ` [for-next PATCH 2/2] PM / devfreq: more documentation warning fixes next set Nishanth Menon
2012-10-26 0:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6833848.UlMixi1sUD@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=kyungmin.park@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rajagopal.venkat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox