From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Feiyang Chen <chenfeiyang@loongson.cn>
Cc: bhelgaas@google.com, rafael.j.wysocki@intel.com,
Mika Westerberg <mika.westerberg@linux.intel.com>,
helgaas@kernel.org, anders.roxell@linaro.org,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
guyinggang@loongson.cn, siyanteng@loongson.cn,
chenhuacai@loongson.cn, loongson-kernel@lists.loongnix.cn,
chris.chenfeiyang@gmail.com
Subject: Re: [PATCH v2] PCI/PM: Only read PCI_PM_CTRL register when available
Date: Wed, 23 Aug 2023 10:28:36 +0300 (EEST) [thread overview]
Message-ID: <68a839ff-817e-c5b6-c0a9-7862792786c2@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0hpngg6WF7Q2P-MhcTGN8qtAx2U2-ODm=YMzs9=C44DSQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
On Tue, 22 Aug 2023, Rafael J. Wysocki wrote:
> On Tue, Aug 22, 2023 at 3:24 PM Ilpo Järvinen
> <ilpo.jarvinen@linux.intel.com> wrote:
> >
> > On Tue, 22 Aug 2023, Feiyang Chen wrote:
> >
> > > When the current state is already PCI_D0, pci_power_up() will return
> > > 0 even though dev->pm_cap is not set. In that case, we should not
> > > read the PCI_PM_CTRL register in pci_set_full_power_state().
> >
> > IMHO, this is a bit misleading because after this patch, pci_power_up()
> > returns always an error if dev->pm_cap is not set.
>
> Yes, it does, but it has 2 callers only and the other one ignores the
> return value, so this only matters here.
I did only mean that the changelog could be more clear how it achieves
the desired result (as currently it states opposite of what the code
does w.r.t. that return value).
I'm not against the approach taken by patch.
--
i.
next prev parent reply other threads:[~2023-08-23 7:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 11:55 [PATCH v2] PCI/PM: Only read PCI_PM_CTRL register when available Feiyang Chen
2023-08-22 13:06 ` Anders Roxell
2023-08-22 13:17 ` Ilpo Järvinen
2023-08-22 13:24 ` Ilpo Järvinen
2023-08-22 14:24 ` Rafael J. Wysocki
2023-08-23 7:28 ` Ilpo Järvinen [this message]
2023-08-23 12:46 ` Rafael J. Wysocki
2023-08-23 20:50 ` Bjorn Helgaas
2023-08-24 1:27 ` Feiyang Chen
2023-08-22 18:54 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68a839ff-817e-c5b6-c0a9-7862792786c2@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=anders.roxell@linaro.org \
--cc=bhelgaas@google.com \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@loongson.cn \
--cc=chris.chenfeiyang@gmail.com \
--cc=guyinggang@loongson.cn \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=siyanteng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox