From: <dan.j.williams@intel.com>
To: Joe Perches <joe@perches.com>, <dan.j.williams@intel.com>,
Ally Heev <allyheev@gmail.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Andy Whitcroft <apw@canonical.com>
Cc: <workflows@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
David Hunter <david.hunter.linux@gmail.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Viresh Kumar <vireshk@kernel.org>, "Nishanth Menon" <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-pm <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] add check for pointers with __free attribute initialized to NULL
Date: Fri, 24 Oct 2025 11:37:37 -0700 [thread overview]
Message-ID: <68fbc771199cc_10e91006d@dwillia2-mobl4.notmuch> (raw)
In-Reply-To: <df0d47c9ca7e984a38f56c6f0ca4696cd4ff1b21.camel@perches.com>
Joe Perches wrote:
[..]
> > > And there are a lot of them.
> > >
> > > $ git grep -P '\b__free\b.*=\s*NULL\s*;' | wc -l
> > > 490
> >
> > That is significant. ...but you did say "almost" above. What about
> > moving this from WARN level to CHK level?
>
> I have no idea how many instances in the tree are inappropriate.
> Do you? I believe it to be a difficult analysis problem.
>
> But given the number is likely to be extremely low, I think it should
> not be added to checkpatch even as a CHK.
>
> If you can show that the reporting rate of defects is significant,
> say >10%, then OK, but I rather doubt it's that high.
Fair enough. Ally, thanks for taking a look.
next prev parent reply other threads:[~2025-10-24 18:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 17:29 [PATCH v2 0/2] checkpatch: add checks incorrectly initialized pointers with __free attr Ally Heev
2025-10-24 17:29 ` [PATCH v2 1/2] checkpatch: add uninitialized pointer with __free attribute check Ally Heev
2025-10-24 18:14 ` Joe Perches
2025-10-25 3:37 ` ally heev
2025-10-24 17:29 ` [PATCH v2 2/2] add check for pointers with __free attribute initialized to NULL Ally Heev
2025-10-24 18:01 ` Joe Perches
2025-10-24 18:14 ` dan.j.williams
2025-10-24 18:23 ` Joe Perches
2025-10-24 18:37 ` dan.j.williams [this message]
2025-10-25 6:17 ` ally heev
2025-10-24 18:08 ` Dan Carpenter
2025-10-25 6:23 ` ally heev
2025-10-27 5:27 ` Dan Carpenter
2025-10-27 8:34 ` ally heev
2025-10-25 6:29 ` ally heev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68fbc771199cc_10e91006d@dwillia2-mobl4.notmuch \
--to=dan.j.williams@intel.com \
--cc=allyheev@gmail.com \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dan.carpenter@linaro.org \
--cc=david.hunter.linux@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vireshk@kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).