From: Phil Reid <preid@electromag.com.au>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Sebastian Reichel <sre@kernel.org>,
Karl-Heinz Schneider <karl-heinz@schneider-inet.de>
Cc: linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] power: supply: sbs-message: double left shift bug in sbsm_select()
Date: Tue, 7 Nov 2017 23:18:49 +0800 [thread overview]
Message-ID: <6bf6a1bf-9f45-7ca3-214c-cbe554dad433@electromag.com.au> (raw)
In-Reply-To: <20171107124322.mm3fqkrggw3zidrx@mwanda>
On 7/11/2017 20:43, Dan Carpenter wrote:
> The original code does this: "1 << (1 << 11)" which is undefined in C.
>
> Fixes: dbc4deda03fe ("power: Adds support for Smart Battery System Manager")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>>From static analysis. Not tested.
>
> diff --git a/drivers/power/supply/sbs-manager.c b/drivers/power/supply/sbs-manager.c
> index ccb4217b9638..cb6e8f66c7a2 100644
> --- a/drivers/power/supply/sbs-manager.c
> +++ b/drivers/power/supply/sbs-manager.c
> @@ -183,7 +183,7 @@ static int sbsm_select(struct i2c_mux_core *muxc, u32 chan)
> return ret;
>
> /* chan goes from 1 ... 4 */
> - reg = 1 << BIT(SBSM_SMB_BAT_OFFSET + chan);
> + reg = BIT(SBSM_SMB_BAT_OFFSET + chan);
> ret = sbsm_write_word(data->client, SBSM_CMD_BATSYSSTATE, reg);
> if (ret)
> dev_err(dev, "Failed to select channel %i\n", chan);
>
>
Oops. That's my fault.
Reviewed-by: Phil Reid <preid@electromag.com.au>
--
Regards
Phil Reid
next prev parent reply other threads:[~2017-11-07 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 12:43 [PATCH] power: supply: sbs-message: double left shift bug in sbsm_select() Dan Carpenter
2017-11-07 15:18 ` Phil Reid [this message]
2017-11-13 10:55 ` Sebastian Reichel
2017-11-13 11:02 ` Wolfram Sang
2017-11-15 7:45 ` Wolfram Sang
2017-11-15 10:05 ` Sebastian Reichel
2017-12-01 15:27 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bf6a1bf-9f45-7ca3-214c-cbe554dad433@electromag.com.au \
--to=preid@electromag.com.au \
--cc=dan.carpenter@oracle.com \
--cc=karl-heinz@schneider-inet.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox