From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A930C4A8A12 for ; Fri, 11 Sep 2026 17:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789148037; cv=none; b=m/8fljgBewSEKnKHO7QoAXql/2KDMDS+6qJZKyDVCMV+rWSzcy0AuCn250DDPA/okdad99EeF+hX/3KCit1+1LY4HBQ8A+Q96NNgFw8XbzaZ5dg6laGf9liMgm2I6Pd91gbeyuE4ViUMnqYPfDY4rULiQMu9Wi93QLpapzNVZVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789148037; c=relaxed/simple; bh=EPB9jOzHRtxTVRXGIwA8nn0Paav15K4HqTW5Cby2kBM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jIcNQ1dUvMEtNkZf3d4JsttcRKpzwKjqYIiRB4D0L4EC7ZQdmE8u+AWLbRKN2T62YLLI4y11Ej24B1/5szNla5GBfXNYcqyazSNmrWbyGyISLPH4ekrE5tF7lDfIUZhVMtTg17auA71wE0rjxeW4dGqxTjsWFE5gYlLMzPsfkZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cc/b+z6x; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZdQh8S4O; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cc/b+z6x"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZdQh8S4O" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68BHWH1A1738738 for ; Fri, 11 Sep 2026 17:33:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EPB9jOzHRtxTVRXGIwA8nn0Paav15K4HqTW5Cby2kBM=; b=cc/b+z6x51RqC4LR +sEC5aT9eXjCvmigj+mJVB7E4YMABRFH0qxeo8tng4VITpnJtyi2DTEFxcxdHtp+ Z/TMZKgb7RUG9Ysd6wln2/M0fwunLiU9RH8GMf4K6kHDQmLUR/7HSLe2wMlUh4e7 bPyyeWzllqme2cw0df9qRe3HWT/mzLgUvbSsapvB5zE/Ayo70PPEWsad+vxBJ9Ex DIHlg5TNaU1s4/WSLwdBaOp6LStNMUpL9Te1UJE7n1Xo2VIgdcOi15JY/UXkq1RG 07kggEPNWEvfgkWR0yN5/brxtxfcss29TeSBJkkhyiAR9Sw7Ow3y2SfJdDbTLFiM DbY4wA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmp0m019w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 11 Sep 2026 17:33:47 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-39512608fb1so2609463a91.1 for ; Fri, 11 Sep 2026 10:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789148027; x=1789752827; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EPB9jOzHRtxTVRXGIwA8nn0Paav15K4HqTW5Cby2kBM=; b=ZdQh8S4ORZu7O5ekv8y3hjYdmyOtf1eONoKDhim+GdJ9vxluas5uu0an0PLTa/EJ9a llNJ+8Ky7HJnw11XVWvUBmwpJjsooBIRY/sEkFX4tilwkjt9/3WfXvHpQ/KwwPRtnKbl 7MYaxn1EU7R+EJSzm1HEsMk9AH/bGjgrRkuGnDycwGvRSR7/lmJmckXGLayCUPicGyb2 +VusMOL6/shlKbsJLezTccFbvvLF7mJcbvRhEpzkAZqB1gSKn5QP5nhSnz0WZU8gZTYc u4LwMNK3MbPTaEhsf/HOkdQror8vI1M4ODA910Z3f8EXBX3jAC82wYblVUN0iGjHUtmI F01A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789148027; x=1789752827; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EPB9jOzHRtxTVRXGIwA8nn0Paav15K4HqTW5Cby2kBM=; b=LpS89h6jR/COpR4QpSTX6LOnNND+EtVKw/9LGrWFlh+j6iCdbq31UXYdNvMJaCUjyH 8voeOlRV2szfctnpelasj2fbfslaEmPtQmqCInQfxI2OyNtRvaZlizsvJ3+Y0N6Teae4 eczUCW2Pa1jRzNLOsY+0M4ii0PDEccFP9BST/QavaLzgnSt4bUlbT8mJKx60OEnJKMDD Xef0Mip/9c0RHKvTLkO+zqtltHKrpC2i6oz7z5lFt7hnQOwkw9Oq5RudDKmXVsKa/+Er wWjcArN7+N+hYXcnRbYF9frVR0r8Djdt8ZPCnt8dRtyhyVY1PxYVIhag4zwe2mIYQAoF vNJg== X-Forwarded-Encrypted: i=1; AKwUvBzs8xjoEjtFMuv4JwnTZtnUOAmibpNms2oCZ6O1mCtPeueo2ebI7Muc6NtJC5yWbSpd9owTBid7Ew==@vger.kernel.org X-Gm-Message-State: AFuF++mqJR9tWAvFE1360F+nDLG5HWmMyTEDXcCeBU4HcNQb05MXKITI S6Swl0TABgFoLNyHkAO5OIAUzn76GE6Q4qeZ4tJMPZF/ZqREYOh11XZAFFk0xJcvTgu/tRMiTzm sV01nBXhlSM7gCHv4ImyGcQ33cqiWgGuq2Z2KHRrkpesDlJieqIt2QjuFEj2ipw== X-Gm-Gg: AYBFou3Bfd7J1ZMAzHGvEEg9uARbNitpQn+fEJRxfOJUP1Nd//kriz8UsDnW/ncOwuw UKkntpNo08wUjNOdjvi17MoQI8YaJCggit4vY3vxxn31uU947vUD55z9ColSrealp8KhSP0M+vF Z7TvgWSFFTRocgFGVbra0Qz0Zg+EuErFqytrhB+Oo6qQ2LBRhdEzww6Z4kTEkMVdQpfJLUia9ee W5u1+FI2mKhfF9aPA+aC7iC4QxhuBMJ778ztPKU5IMauEzpWj5JCY9h4AXzRgxbhGVNqd8DP48D 2oMstgKY8xqzXsIvA21wt2oeoihEjmYQAQvvIb8DoNBTTtfVnY9A4boRsQ7kuugdhKHFF8QMF6Q C5FQX9acJ4SbwvuA7/lQ9KLM2KaU5NrUF X-Received: by 2002:a17:90a:da8f:b0:396:6344:3b63 with SMTP id 98e67ed59e1d1-39d9bbee490mr8584049a91.2.1789148026771; Fri, 11 Sep 2026 10:33:46 -0700 (PDT) X-Received: by 2002:a17:90a:da8f:b0:396:6344:3b63 with SMTP id 98e67ed59e1d1-39d9bbee490mr8583885a91.2.1789148024735; Fri, 11 Sep 2026 10:33:44 -0700 (PDT) Received: from [192.168.0.6] ([49.204.105.169]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d98a58d23sm6853266a91.2.2026.09.11.10.33.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Sep 2026 10:33:44 -0700 (PDT) Message-ID: <6c28e672-349c-49cb-892d-ec521b3004bf@oss.qualcomm.com> Date: Fri, 11 Sep 2026 23:03:36 +0530 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/9] soc: qcom: geni: Derive SE clock configuration from OPP table on SA8255P To: Konrad Dybcio , Ulf Hansson Cc: Sudeep Holla , Cristian Marussi , Ulf Hansson , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Mark Brown , Viken Dadhaniya , Andi Shyti , mukesh.savaliya@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org, Abel Vesa References: <20260827-derive_clk_perf_tbl_from_perf_domain_opp_table-v2-0-091697dbeb02@oss.qualcomm.com> <177884a8-902f-49be-8fcb-b2bec3ec7d6c@oss.qualcomm.com> <0f5494c7-c3c1-4668-a09f-d8c43d1c58b9@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <0f5494c7-c3c1-4668-a09f-d8c43d1c58b9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDI0NSBTYWx0ZWRfX3BMENeIRVOKb fpGJ3uzOPx0ufNhL5D2GVKNoNTnOzM7KGDwVlQ2uHQmmRAPh5Oel46hdD8TTeYeHEdxJ0lHkfgQ Vz33QqJoq0C4PP4DaJ+wiV/l0nNDNOA= X-Authority-Analysis: v=2.4 cv=W7etxhWk c=1 sm=1 tr=0 ts=6aa43b7b cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=KFINdI5Z0390/lZYonNNQw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=iiE2cmy92MJpIBaOhi4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: 3b9_fcMah3GS48CsRkS777aWvR3AO2FO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDI0NSBTYWx0ZWRfXwqtcBLxXib7t Zovjz5XLpG8BVPwTIlu3kpvQuRTSenXeirDnIKPNk4IxQ52YNF+m4lUVt0flkukp7RU2MHxq+6j 7qIr98VpsGmNDOawgwzYNsogeiM9XjoGF2Tp5N59hTKFejy+b4IWCoNImSglBB8sWv+mHhiRYsV 7WSuafPpzRCywwOXaIgG5QzRwnFf2FcGELg3FsCJMDwNapHRa/ljVpygHag79Mkm43SHLqztBja zGCzLxR5oCf1bJLNFUdeKanqU9QU9UuYod9poLq7oaKGmwzPZ1IEp0p23B9aPV4hyFzVHENwuAl dACda1+ctBVCrwEJNcrxxVd9HoU8OnDlBu7JOuPVH5VddXOEVImuy8pFtkB2QQ/spymaUkJlafj SlHKPjcOO8MBmGFOKYZH2i+O3mPJLc99UJ+RpG5OXJIBhg/Q+C3l3yeNC+RHdagfDDQRnLeOeJp 0mWq8T70aOQ0De76VGQ== X-Proofpoint-ORIG-GUID: 3b9_fcMah3GS48CsRkS777aWvR3AO2FO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_06,2026-09-11_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110245 Hi Konrad, On 04-09-2026 14:30, Konrad Dybcio wrote: > On 9/4/26 9:56 AM, Ulf Hansson wrote: >> On Tue, Sep 1, 2026 at 6:48 PM Praveen Talari >> wrote: > [...] > >> So geni_se_clk_freq_match() is used by two consumer drivers today, >> drivers/spi/spi-geni-qcom.c and drivers/tty/serial/qcom_geni_serial.c. >> >> Beyond the $subject series, there will be even more consumer drivers >> that call these platform specific functions. As I said above, I don't >> think this is moving things in the right direction. >> >> If this can't be solved with generic frameworks (clocks and OPP), >> please clarify why so we can figure out a better way forward. > The way I read it, isn't geni_se_clk_freq_match() more or less > dev_pm_opp_find_freq_exact() called in a loop with an increasing > divider? Currently, geni_se_clk_freq_match() relies on clk_perf_tbl to determine the source clock index and divider corresponding to a requested frequency. On Linux-managed platforms, clk_perf_tbl is populated by geni_se_clk_tbl_get(), which enumerates the supported source clock frequencies using clk_round_rate(). int geni_se_clk_freq_match(struct geni_se *se, unsigned long req_freq,                unsigned int *index, unsigned long *res_freq,                bool exact) {     [...]     num_clk_levels = geni_se_clk_tbl_get(se, &tbl);     if (num_clk_levels < 0)         return num_clk_levels;     [...]     best_delta = ULONG_MAX;     for (i = 0; i < num_clk_levels; i++) {         divider = DIV_ROUND_UP(tbl[i], req_freq);         new_delta = req_freq - tbl[i] / divider;         if (new_delta < best_delta) {             /* We have a new best! */             *index = i;             *res_freq = tbl[i];             /* If the new best is exact then we're done */             if (new_delta == 0)                 return 0;             /* Record how close we got */             best_delta = new_delta;         }     } [...]     return 0; } On firmware-managed platforms, clk_perf_tbl is populated from the performance-domain OPP table during domain attachment, allowing geni_se_clk_freq_match() to operate on the same source clock frequency information irrespective of how the underlying resources are managed. As a result, the frequency matching logic, including source clock selection and divider calculation, remains common across both Linux-managed and firmware-managed configurations, while only the mechanism used to apply the selected rate differs. Thanks, Praveen Talari > > Konrad