From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D74C433EF for ; Wed, 25 May 2022 16:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245393AbiEYQF2 (ORCPT ); Wed, 25 May 2022 12:05:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245369AbiEYQFP (ORCPT ); Wed, 25 May 2022 12:05:15 -0400 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AA2CB41D6 for ; Wed, 25 May 2022 09:05:14 -0700 (PDT) Received: by mail-il1-x12f.google.com with SMTP id 3so14145718ily.2 for ; Wed, 25 May 2022 09:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WniLzB5SiRVqHzMZUCEbBv/kb3dmETbEX6p4Sn4Jrug=; b=cTa6aTwIXDVE5TRe6Qutp+ruroH5hAjEPMipG9ObxavNkGtrvXeGz3CHRE0RiRNypT g5bcFQj1rQo7GETNNu6Oi+qLi3ZhffzsRFLW51cfiG2dJ9Zwf/ywTwzXPQuirzfi0+tP Oq2G6ZHlT7xd/IIPTAuUhY62o7d70tqnsEvDY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WniLzB5SiRVqHzMZUCEbBv/kb3dmETbEX6p4Sn4Jrug=; b=HfiiOsZD7tdNIJwScgib+0wPop1P/IBid506gzhJowHOHg3uaab9YM2XgdDhesTn2C Ubm+xfdUjGV1cyfzcA9tnrIy2iD9BAW3ZChy85LdYrlTf8qsOm6ffBmXuV1yG5/Lk9bE lUpeGxxqeFNAo+j2MIh6VOAum7RqBLbi+j2Wtq75436M125hzu+b5eiB5P4B0kJbe0zS SdW6WAjgDTj3WWuxPr5T4jEqdY5j87X6BTg2fbEsBborWtonm6ZE9gKWWWOT4s+Z+9J6 HxTfVLoraGLxuFHK86owCFZm6RXo3QQhfmNezjvIOBdg/rh+7EwMM+ugChQzKxd5AwHA VCrw== X-Gm-Message-State: AOAM53373K7I/9ZirYI/rYP933nT1qNoE30GjKy7CzDxImJU1zSF+w8s sVYAp+2eziE/A8QkLJwtWeHz9g== X-Google-Smtp-Source: ABdhPJxPVFqJ+rxPJ/rSNc6KMtA5495jM0Ok6y/rfEw/mHFvhZlHY7xyDacOZBhSkKetr3O3vJ5dcA== X-Received: by 2002:a92:ca0d:0:b0:2d1:aa92:4da6 with SMTP id j13-20020a92ca0d000000b002d1aa924da6mr8792361ils.107.1653494713626; Wed, 25 May 2022 09:05:13 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id c17-20020a023b11000000b0032e6f0d3796sm4209055jaa.145.2022.05.25.09.05.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 09:05:13 -0700 (PDT) Subject: Re: [PATCH V7 2/4] cpufreq: amd-pstate: Add test module for amd-pstate driver To: Meng Li , Huang Rui , linux-pm@vger.kernel.org Cc: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , Alex Deucher , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , linux-kernel@vger.kernel.org, Shuah Khan References: <20220522115423.1147282-1-li.meng@amd.com> <20220522115423.1147282-3-li.meng@amd.com> From: Shuah Khan Message-ID: <6e3cdf37-299a-98df-1143-c3392e9acec0@linuxfoundation.org> Date: Wed, 25 May 2022 10:05:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220522115423.1147282-3-li.meng@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 5/22/22 5:54 AM, Meng Li wrote: > Add amd-pstate-ut module, which is conceptually out-of-tree module I didn't notice this before. Let's get rid of "out-of-tree" workding. > and provides ways for selftests/amd-pstate driver to test various > kernel module-related functionality. This module will be expected by > some of selftests to be present and loaded. > What does "various kernel module-related functionality" mean. Can we rephrase this to say "this module is used by kselftest to unit test amd-pstate functionality" ? > Signed-off-by: Meng Li > Acked-by: Huang Rui > --- [snip] > + > +module_init(amd_pstate_ut_init); > +module_exit(amd_pstate_ut_exit); > + > +MODULE_AUTHOR("Meng Li "); > +MODULE_DESCRIPTION("Kselftest for AMD P-state driver"); Change this to "AMD P-state driver Test module" Having Kselftest in the name is confusing. It is a test driver that kselftest amd_pstate_test depends on. > +MODULE_LICENSE("GPL"); > With these above changes: Reviewed-by: Shuah Khan thanks, -- Shuah