From: Randy Dunlap <rdunlap@infradead.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>
Cc: suleiman@google.com, briannorris@google.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v5] PM: sleep: Expose last succeeded resumed timestamp in sysfs
Date: Mon, 27 Nov 2023 15:47:01 -0800 [thread overview]
Message-ID: <6e664be1-dc6b-461e-b75d-2be49641402c@infradead.org> (raw)
In-Reply-To: <170108152012.780347.6355289232990337333.stgit@mhiramat.roam.corp.google.com>
Hi--
On 11/27/23 02:38, Masami Hiramatsu (Google) wrote:
> From: Masami Hiramatsu <mhiramat@kernel.org>
>
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index f6425ae3e8b0..2ab23fd3daac 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -514,6 +526,9 @@ static int suspend_stats_show(struct seq_file *s, void *unused)
> suspend_step_name(
> suspend_stats.failed_steps[index]));
> }
> + seq_printf(s, "last_success_resume_time:\t%-llu.%llu\n",
The <TAB> after "s," is a bit odd IMO, but I don't see a need to resend it
just for that.
> + (unsigned long long)suspend_stats.last_success_resume_time.tv_sec,
> + (unsigned long long)suspend_stats.last_success_resume_time.tv_nsec);
>
> return 0;
> }
--
~Randy
next prev parent reply other threads:[~2023-11-27 23:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 10:38 [PATCH v5 0/1] PM: sleep: Expose last succeeded resumed timestamp in sysfs Masami Hiramatsu (Google)
2023-11-27 10:38 ` [PATCH v5] " Masami Hiramatsu (Google)
2023-11-27 23:47 ` Randy Dunlap [this message]
2023-11-29 13:18 ` Masami Hiramatsu
2023-12-12 13:39 ` Rafael J. Wysocki
2023-12-12 14:32 ` Masami Hiramatsu
2023-12-12 14:57 ` Rafael J. Wysocki
2023-12-12 22:19 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e664be1-dc6b-461e-b75d-2be49641402c@infradead.org \
--to=rdunlap@infradead.org \
--cc=briannorris@google.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=suleiman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).