From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yang Li <yang.li@amlogic.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: power: Add power sequence for Amloigc WCN chips
Date: Mon, 8 Jul 2024 08:11:22 +0200 [thread overview]
Message-ID: <726a0561-b3fc-46bb-a834-3ed8b0e993e1@kernel.org> (raw)
In-Reply-To: <9c550278-2205-4663-917c-c303c65726ad@amlogic.com>
On 08/07/2024 08:04, Yang Li wrote:
>>> +
>>> +required:
>>> + - compatible
>>> + - clocks
>>> + - clock-names
>>> + - amlogic,chip-enable-gpios
>>> + - amlogic,bt-enable-gpios
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/gpio/gpio.h>
>>> + wcn_pwrseq {
>> No underscores in node names, generic node names.
>>
>> There is no device as "pwrseq". I also do not get what "wcn" means here.
>
> Yes, I understand.
>
> Can I change "wcn_pwrseq" to "pmu", and do I need to change the binding
What is pmu for your device? What is this device in the first place you
are documenting? Where is the datasheet?
> file name to "amlogic,w155s2-pmu"
Yes, compatible should also match proper device.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-08 6:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 11:13 [PATCH 0/3] Add power sequence for Amlogic WCN chips Yang Li via B4 Relay
2024-07-05 11:13 ` [PATCH 1/3] dt-bindings: power: Add power sequence for Amloigc " Yang Li via B4 Relay
2024-07-05 13:34 ` Bartosz Golaszewski
2024-07-08 6:12 ` Yang Li
2024-07-07 12:59 ` Krzysztof Kozlowski
2024-07-08 6:04 ` Yang Li
2024-07-08 6:11 ` Krzysztof Kozlowski [this message]
2024-07-08 6:32 ` Yang Li
2024-07-08 7:32 ` Krzysztof Kozlowski
2024-07-08 8:21 ` Yang Li
2024-07-08 9:10 ` Krzysztof Kozlowski
2024-07-08 9:36 ` Bartosz Golaszewski
2024-07-05 11:13 ` [PATCH 2/3] power: sequenceing: Add power sequence for Amlogic " Yang Li via B4 Relay
2024-07-05 13:46 ` Bartosz Golaszewski
2024-07-10 3:00 ` Yang Li
2024-07-07 13:02 ` Krzysztof Kozlowski
2024-07-08 7:41 ` Yang Li
2024-07-05 11:13 ` [PATCH 3/3] MAINTAINERS: Add an entry for Amlogic WCN power sequence Yang Li via B4 Relay
2024-07-07 13:04 ` Krzysztof Kozlowski
2024-07-08 6:34 ` Yang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=726a0561-b3fc-46bb-a834-3ed8b0e993e1@kernel.org \
--to=krzk@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=yang.li@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox