Re: [PATCH] PM: Use hibernate flows for system power off

[Mario Limonciello <superm1@kernel.org>]

On 5/14/2025 11:30 AM, Martin Steigerwald wrote:
> Hi.
> 
> Mario Limonciello - 14.05.25, 18:15:00 CEST:
>>> Hello,
>>>
>>> As for the previous version this patch makes my laptop shutdown
>>> cleanly very quickly and I could not link to any regressions or
>>> change in behavior while laptop is on.
>>>
>>> Tested-by: Denis Benato <benato.denis96@gmail.com>
>>
>> Thanks Denis, that's great news to hear.
> 
> Thanks!
> 
>> FTR I noticed that this needs some error handling in case the hibernate
>> flows fail, so assuming Rafael is generally amenable to this direction
>> the next spin I'll add something like this instead to fall back to the
>> previous shutdown flow if that happens.
> 
> I do not know the context of this patch except this mailing list thread.
> 
> However… on various ThinkPads I had the issue of the device not powering
> down with certain kernel versions. Not even during a normal shutdown
> attempt. Also not with hibernation to disk. Still holding on to an older
> kernel version for a X260 for example. But also a T14 AMD Gen 1 is
> affected no longer in frequent use currently while a T14 AMD Gen 2 is
> absolutely fine. Could this patch help with that?

If the root cause of your issue with the inability to shut down is that 
there were devices left in D0 at shutdown and the firmware was expecting 
them to be powered down then this patch may help your system.

If it is a different problem then I wouldn't expect any differences from 
this patch.

> 
> I will eventually see I bet.
> 
> Currently I only compile my own kernel for my current ThinkPad which is
> not affected by this issue.
> 
> Best,

As a debugging tactic for your problem you can try to save your shutdown 
log to the EFI pstore by adding this to your kernel command line for a 
boot.

efi_pstore.pstore_disable=N printk.always_kmsg_dump=Y

Then the next boot if you have the systemd-pstore service enabled it 
will move the log into /var/lib/systemd/pstore.

If you don't have it enabled you can run this to manually do it one time.

sudo systemctl start systemd-pstore.service

Hopefully that log will be helpful in identifying your problem.

Note: Don't do this "every" boot; it's going to apply more wear to the 
NVRAM backing.