From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A7CDC83F01 for ; Wed, 30 Aug 2023 18:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237079AbjH3Sgf (ORCPT ); Wed, 30 Aug 2023 14:36:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243339AbjH3KpX (ORCPT ); Wed, 30 Aug 2023 06:45:23 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69ECACCB for ; Wed, 30 Aug 2023 03:45:19 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-500c37d479aso2583011e87.2 for ; Wed, 30 Aug 2023 03:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693392317; x=1693997117; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yXrmFSc5DvtKQwplkdMyHW9pMnpsWmyWrqSLE5MlrIE=; b=UXawE5igQfDnP9Kg2O1Y9MNow2oAyrd+dCUx+bDlftaExBOzl+mIoVzGsMTd+miBJ+ TCT8nkj//Xdk1TvwcHks1PpJFUMPoh9PakzV6CUjPkOjO3hF7zpkypMAa+ANLj45cp6e jvXfovC0xuwD446pzBFtESyjQn/rvXS7Kd7M8Kr43nOwsM09b3N4jUpKJLeA/cIA8BUY BksF/mvNADzsgeMK6V15/zc6T0Iahu+4JzSmpvdUhVjk4fiYjgMpiP2eHebE6HXwD8Et VnpfkLGjP0l+2lzshc03rZyyvm7k9F8gU6mlt701W3XOgvxfPT9GR9hbpgf5jCi3sriv FOUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693392317; x=1693997117; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yXrmFSc5DvtKQwplkdMyHW9pMnpsWmyWrqSLE5MlrIE=; b=QdEXR/e48uZeHgMOjH4gISHAHB+Z3kVwoziYIz5E/Td3z98g/0aoDZAAXi3z4qpT3g n4VNs8e1LLZa4dXODk0+A7cqF9lnoE9hEiSOvYmuay5VHtSpoPpYoiH5h1YNbNlBe+av q12dOMFUi11t9AnoDWcTCJV1R3FCX7x0SJ03BmQp5LB7A7P8uCQtNUc3Csat5DnrPZUX OPR0uOsZ4wPTz+QB3d71VAkRRELpsvgyctzDmQMHgMGegofKISsZeuY1x0gDo8J1EwMk d1jJbbCU0vawKBz4l7B05sBy6FI5cfJ1RqGyIzn2dZ2kGUIOewSerIS+5aCIPx3slV3j QqdA== X-Gm-Message-State: AOJu0YygT/ERqn8JkUFlRQJC/xR0g6PQIX1eR9tclp8qDl8HvOwV0cfv 3vVpi4Rs6m8ZvWh7dvv2dJkqGQ== X-Google-Smtp-Source: AGHT+IEIBTX67B4U3Kx8acXRvk5tJixSnsBIFI4vYjn84H8gWbTM8Nf/ZI8sQkkfwDxkK91FgFiYSA== X-Received: by 2002:a05:6512:ba4:b0:500:9031:bb1b with SMTP id b36-20020a0565120ba400b005009031bb1bmr1361380lfv.41.1693392317539; Wed, 30 Aug 2023 03:45:17 -0700 (PDT) Received: from [192.168.1.101] (abyl195.neoplus.adsl.tpnet.pl. [83.9.31.195]) by smtp.gmail.com with ESMTPSA id j17-20020a19f511000000b004ff6fa3f038sm2316808lfb.144.2023.08.30.03.45.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Aug 2023 03:45:17 -0700 (PDT) Message-ID: <72c2fd33-613b-49be-b394-0663f459f0c5@linaro.org> Date: Wed, 30 Aug 2023 12:45:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/11] arm64: dts: qcom: qcm6490: Add device-tree for Fairphone 5 Content-Language: en-US To: Luca Weiss , cros-qcom-dts-watchers@chromium.org, Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Linus Walleij , "Rafael J. Wysocki" , Viresh Kumar Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org References: <20230830-fp5-initial-v1-0-5a954519bbad@fairphone.com> <20230830-fp5-initial-v1-11-5a954519bbad@fairphone.com> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20230830-fp5-initial-v1-11-5a954519bbad@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 30.08.2023 11:58, Luca Weiss wrote: > Add device tree for the Fairphone 5 smartphone which is based on > the QCM6490 SoC. > > Supported features are, as of now: > * Bluetooth > * Debug UART > * Display via simplefb > * Flash/torch LED > * Flip cover sensor > * Power & volume buttons > * RTC > * SD card > * USB > * Various plumbing like regulators, i2c, spi, etc > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 659 +++++++++++++++++++++ > 2 files changed, 660 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 2cca20563a1d..73c3be0f8872 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -81,6 +81,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-lilac.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8998-xiaomi-sagit.dtb > +dtb-$(CONFIG_ARCH_QCOM) += qcm6490-fairphone-fp5.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > new file mode 100644 > index 000000000000..572b254d3af2 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > @@ -0,0 +1,659 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2023, Luca Weiss > + */ > + > +/dts-v1/; > + > +/* PM7250B is configured to use SID8/9 instead of SID2/3 */ > +#define PM7250B_SID 8 > +#define PM7250B_SID1 9 > + > +#include > +#include > +#include > +#include > +#include "sc7280.dtsi" > +#include "pm7250b.dtsi" > +#include "pm7325.dtsi" > +#include "pm8350c.dtsi" /* PM7350C */ > +#include "pmk8350.dtsi" /* PMK7325 */ > + > +/ { > + model = "Fairphone 5"; > + compatible = "fairphone,fp5", "qcom,qcm6490"; > + chassis-type = "handset"; > + > + /* required for bootloader to select correct board */ > + qcom,msm-id = ; > + qcom,board-id = <34 0>; Try [1], it worked for me on a picky device. > + > + aliases { > + serial0 = &uart5; > + serial1 = &uart7; > + }; > + > + chosen { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + framebuffer0: framebuffer@a000000 { > + compatible = "simple-framebuffer"; > + reg = <0 0xe1000000 0 (2700 * 1224 * 4)>; 0x0? > + width = <1224>; > + height = <2700>; > + stride = <(1224 * 4)>; > + format = "a8r8g8b8"; > + panel = <&panel>; > + clocks = <&gcc GCC_DISP_HF_AXI_CLK>; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-0 = <&volume_down_default>, <&hall_sensor_default>; > + pinctrl-names = "default"; > + > + key-volume-up { > + label = "Volume up"; > + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>; > + linux,code = ; > + }; > + > + /* Hall sensor uses vreg_l8c as VDD, it's being enabled using > + * always-on on the regulator > + */ /* Powered by the always-on vreg_l8c */ - fits in a single line > + event-hall-sensor { > + label = "Hall Effect Sensor"; > + gpios = <&tlmm 155 GPIO_ACTIVE_LOW>; > + linux,input-type = ; > + linux,code = ; > + linux,can-disable; > + wakeup-source; > + }; > + }; > + > + panel: panel { > + compatible = "boe,rm692e5"; Undocumented compatbile > + > + width-mm = <68>; > + height-mm = <150>; > + }; > + > + reserved-memory { > + cont_splash_mem: cont-splash@e1000000 { > + reg = <0 0xe1000000 0 0x2300000>; 0x0 [...] > + vreg_s1b: smps1 { > + regulator-min-microvolt = <1840000>; > + regulator-max-microvolt = <2040000>; No regulator-initial-mode on this pmic? [...] > + > + /* PM8008 PMIC @ 8 and 9 */ > + /* Pixelworks @ 26 */ > + /* FSA4480 USB audio switch @ 42 */ There's a driver for the fsa4480, you may wanna include a node here > + /* AW86927FCR haptics @ 5a */ > +}; [...] > + > + led-0 { > + function = LED_FUNCTION_FLASH; No dual-tone stuff? > + color = ; > + led-sources = <1>, <4>; > + led-max-microamp = <500000>; > + flash-max-microamp = <1500000>; > + flash-max-timeout-us = <1280000>; > + }; > +}; > + > +&pmk8350_rtc { > + status = "okay"; > +}; > + > +&pon_pwrkey { > + status = "okay"; > +}; > + > +&pon_resin { > + status = "okay"; > + linux,code = ; status last [...] > +&rmtfs_mem { > + qcom,vmid = , ; > + reg = <0x0 0xf8500000 0x0 0x600000>; > +}; /delete-node/ + redefinition would probably be cleaner-looking [...] > +&uart7 { > + /delete-property/interrupts; > + interrupts-extended = <&intc GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>, > + <&tlmm 31 IRQ_TYPE_EDGE_FALLING>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-1 = <&qup_uart7_sleep_cts>, <&qup_uart7_sleep_rts>, <&qup_uart7_sleep_tx>, <&qup_uart7_sleep_rx>; property-n property-names > + > + status = "okay"; > + > + bluetooth: bluetooth { > + compatible = "qcom,wcn6750-bt"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&bluetooth_enable_default>, <&sw_ctrl_default>; property-n property-names Konrad [1] https://lore.kernel.org/linux-arm-msm/9db02015-2c41-40d6-bf35-69ef277e9ce4@linaro.org/