From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] powernow-k8: Add a kconfig dependency on acpi-cpufreq Date: Thu, 17 Jan 2013 13:53:55 +0100 Message-ID: <7359167.GTsCEtNASI@vostro.rjw.lan> References: <1357780161-30581-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <20130117115436.GA3853@pd.tnic> <20130117115844.GB3853@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20130117115844.GB3853@pd.tnic> Sender: cpufreq-owner@vger.kernel.org To: Borislav Petkov Cc: "Gopalakrishnan, Aravind" , Andre Przywara , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andreas List-Id: linux-pm@vger.kernel.org On Thursday, January 17, 2013 12:58:44 PM Borislav Petkov wrote: > From: Borislav Petkov > Date: Thu, 17 Jan 2013 12:44:20 +0100 > Subject: [PATCH] powernow-k8: Add a kconfig dependency on acpi-cpufreq > > Andreas reports in https://bugzilla.kernel.org/show_bug.cgi?id=51741 > that with his Gentoo config, acpi-cpufreq wasn't enabled and powernow-k8 > couldn't handoff properly to acpi-cpufreq leading to running without > P-state support (i.e., cores are constantly in P0). > > To alleaviate that, we need to make powernow-k8 depend on acpi-cpufreq > so that acpi-cpufreq is always present. OK Do we need that in -stable? Rafael > Cc: Andre Przywara > Reported-by: Andreas > Signed-off-by: Borislav Petkov > --- > drivers/cpufreq/Kconfig.x86 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 > index 934854ae5eb4..7227cd734042 100644 > --- a/drivers/cpufreq/Kconfig.x86 > +++ b/drivers/cpufreq/Kconfig.x86 > @@ -106,7 +106,7 @@ config X86_POWERNOW_K7_ACPI > config X86_POWERNOW_K8 > tristate "AMD Opteron/Athlon64 PowerNow!" > select CPU_FREQ_TABLE > - depends on ACPI && ACPI_PROCESSOR > + depends on ACPI && ACPI_PROCESSOR && X86_ACPI_CPUFREQ > help > This adds the CPUFreq driver for K8/early Opteron/Athlon64 processors. > Support for K10 and newer processors is now in acpi-cpufreq. > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.