From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] clk: samsung: fix cpu clock's flags checking Date: Tue, 30 Jun 2015 19:17:51 +0200 Message-ID: <7416838.2ZUPGjSqFp@amdc1976> References: <1435598978-21800-1-git-send-email-b.zolnierkie@samsung.com> <5591DD9B.4030507@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:35245 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbbF3RTK (ORCPT ); Tue, 30 Jun 2015 13:19:10 -0400 In-reply-to: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Javier Martinez Canillas Cc: Krzysztof Kozlowski , Thomas Abraham , Sylwester Nawrocki , Michael Turquette , Kukjin Kim , Kukjin Kim , Viresh Kumar , Dan Carpenter , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Javier Martinez Canillas , "linux-samsung-soc@vger.kernel.org" , linux-clk@vger.kernel.org, "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Hi, On Tuesday, June 30, 2015 08:27:36 AM Javier Martinez Canillas wrote: > On Tue, Jun 30, 2015 at 2:06 AM, Krzysztof Kozlowski > wrote: > > On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote: > >> CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were > >> incorrectly used as a bit numbers. Fix it. > >> > >> Tested on Exynos4210 based Origen board and on Exynos5250 based > >> Arndale board. > >> > >> Cc: Tomasz Figa > >> Cc: Michael Turquette > >> Cc: Javier Martinez Canillas > >> Cc: Thomas Abraham > >> Reported-by: Dan Carpenter > >> Signed-off-by: Bartlomiej Zolnierkiewicz > >> --- > >> drivers/clk/samsung/clk-cpu.c | 10 +++++----- > >> 1 file changed, 5 insertions(+), 5 deletions(-) > > > > Reviewed-by: Krzysztof Kozlowski > > > > Looks good to me as well. > > Reviewed-by: Javier Martinez Canillas Krzysztof has noted that I should use your @dowhile0.org e-mail address instead of @collabora.co.uk one, is this right? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics