From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7731CE7D0A6 for ; Thu, 21 Sep 2023 20:21:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231582AbjIUUVU (ORCPT ); Thu, 21 Sep 2023 16:21:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbjIUUUw (ORCPT ); Thu, 21 Sep 2023 16:20:52 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6B857DB3; Thu, 21 Sep 2023 10:23:15 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id BDBA366072B6; Thu, 21 Sep 2023 08:54:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1695282888; bh=XKfV63HWdKQ6s7HPBY3YhVeOhdzebvODVX7qw3XgXyM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jD9+CmGQSfz4ZX3d2CGSp6+EHhCrCCk4YGT3vBykBF3wqdTzGOXIZCz7QCGMCAUKF yY9nfpT49e8hOI1gUgZME++aIhmRLRNoXiPOyREKIUygnK3mfFMj4/yqGQ79JBK/mr 2c6w7osgDp6Z1woUp6qf6pWKsJk8nqB7RtNZhooW/urn9l2MQMxso2S32xIGx4PVwi CINeOwpiW8/6UskufZ3bdJ3kAYbq/ODd2ko3UGc+loP4zAp6OTqiN46HwjTw09C1+8 1dolr6haDdAjRiWHIrog91ziBrjkseUViVBdgUSUVaJ/e/VlGg/3b+yyLlvNE0fam4 4tT3XHFAZeA9g== Message-ID: <7420791d-a424-2db9-eb68-9f583735d4d7@collabora.com> Date: Thu, 21 Sep 2023 09:54:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2 3/4] thermal/drivers/mediatek/lvts_thermal: make coeff configurable Content-Language: en-US To: Frank Wunderlich , linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230920175001.47563-1-linux@fw-web.de> <20230920175001.47563-4-linux@fw-web.de> From: AngeloGioacchino Del Regno In-Reply-To: <20230920175001.47563-4-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Il 20/09/23 19:50, Frank Wunderlich ha scritto: > From: Frank Wunderlich > > The upcoming mt7988 has different temperature coefficients so we > cannot use constants in the functions lvts_golden_temp_init, > lvts_golden_temp_init and lvts_raw_to_temp anymore. > > Add a field in the lvts_ctrl pointing to the lvts_data which now > contains the soc-specific temperature coefficents. > > To make the code better readable, rename static int coeff_b to > golden_temp_offset, COEFF_A to temp_factor and COEFF_B to temp_offset. > > Signed-off-by: Frank Wunderlich > Now, that's good! Reviewed-by: AngeloGioacchino Del Regno