From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [RFC 3/8] cpufreq: imx6q: Set max suspend_freq to avoid changes during suspend Date: Wed, 29 Mar 2017 00:23:38 +0200 Message-ID: <74548665.CVf2rD9Eyh@aspire.rjw.lan> References: <1490731431.15830.9.camel@nxp.com> <45185440.SBt0mf6LXq@aspire.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from cloudserver094114.home.net.pl ([79.96.170.134]:44945 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932157AbdC1W3g (ORCPT ); Tue, 28 Mar 2017 18:29:36 -0400 In-Reply-To: <45185440.SBt0mf6LXq@aspire.rjw.lan> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Leonard Crestez Cc: Viresh Kumar , Mark Brown , Liam Girdwood , Shawn Guo , Sascha Hauer , Robin Gong , Anson Huang , Irina Tirdea , Rob Herring , Mark Rutland , Fabio Estevam , Octavian Purdila , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org On Tuesday, March 28, 2017 10:50:50 PM Rafael J. Wysocki wrote: > On Tuesday, March 28, 2017 11:03:51 PM Leonard Crestez wrote: > > On Thu, 2017-03-23 at 10:04 +0530, Viresh Kumar wrote: > > > On 22-03-17, 18:53, Leonard Crestez wrote: > > > > If the cpufreq driver tries to modify voltage/freq during suspend/resume > > > > it might need to control an external PMIC via I2C or SPI but those > > > > devices might be already suspended. > > > > > > > > To avoid this scenario we just increase cpufreq to highest setpoint > > > > before suspend. This issue can easily be triggered by ldo-bypass but in > > > > theory any regulator set_voltage call can end up having to modify > > > > external supply voltages. > > > > > > > > Signed-off-by: Leonard Crestez > > > > --- > > > > drivers/cpufreq/imx6q-cpufreq.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > Acked-by: Viresh Kumar > > > > The first couple of patches are obvious fixes despite being marked as > > RFC. It would be great if you could apply them to your tree separately > > Why? > > > from the rest of the series but I'm not sure what the process is here. > > Well, you have to talk to me. OK, so if I understand this correctly, you would like the patches ACKed by Viresh to be applied regardless of what happens to the rest of the series, right? In that case please resend them separately without the [RFC] tag and with the ACKs from Viresh. Thanks, Rafael