From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 139313E95B2 for ; Tue, 20 Jan 2026 23:14:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768950862; cv=none; b=U6Zcbsg57n9dk937HxZ/EdcQrIzCYB3XPKQeM2+5xgaNpXvGCJJMbRInGiYyF4lWs1E5aEriZ8EYH9MWLyOJtA3M/MAYOIeNNTPIK4RvgebsioEbnEjbvPupekS6SScTilHDwXnQcJ3Hk+227gulQiKIlDX1Z48CdoKFyvfmPP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768950862; c=relaxed/simple; bh=RorFZnKGOpMXxF12DBPQ224YDw0c1sGVEyMqQrlvtpQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oB652ZFPJ2ND7gQE9RrActkueodgmsyClNwCZwxCFxm1VMN03JmYaqp0GlSAOoyGrpsvolOdANrVYITmprSF4Y537z0I5Vi491TMwk3/rh7fon7NGDP6UO/B6O5wVFGwK/KTHqzQR2TesSHBB3XCAEoRaBmOuEZ+wNU+DiycoyY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b=gKbRq/kq; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b="gKbRq/kq" Message-ID: <74de8f03-dae1-4bf9-a2a1-973952fee2e1@packett.cool> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=packett.cool; s=key1; t=1768950857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Dx1ZkuxJTJAJ1nIRHVdlZkQt5JO4SJQc0yCogyN8i0=; b=gKbRq/kqhma7PJJPi+fWCJpnygM+IQqdK4al8/qcOSuzBuLUOV5/jNAVfaGEArr7dv9pEK R4nfUUeBPQFnUI4ETDCyrCu8eMuahWq2BkHdruRx6hLCUpeaRvox+Py37k2082SfFdGX3e sLMnWWLQxAFc8RpcM3ouMpY3KdmMKZNF1CsVwCeX1TJzksHgHXMq/4z8itP7ZA/PpgLg0W t4KSX7BkXH/dKhJhw2OjM3sf6xIJ6+fcpXHg6oLBJ6uKetcI2oX15s2q4ICbK9PrlpT36S sFG7rGR+L4wfYi22Qaf6pVozsj5ppSiQwoIkTY7YsJRSJ7GtiublQpWP5kUfzg== Date: Tue, 20 Jan 2026 20:14:12 -0300 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer To: Dmitry Baryshkov Cc: Sebastian Reichel , Abel Vesa , Sebastian Reichel , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260117210941.6219-1-val@packett.cool> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Val Packett In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 1/19/26 3:38 AM, Dmitry Baryshkov wrote: > On Sat, Jan 17, 2026 at 06:09:24PM -0300, Val Packett wrote: >> On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i' >> for the battery chemistry type, but only all-uppercase "LIP" was being >> recognized. Add the CamelCase variant to the check to fix the "Unknown >> battery technology" warning. >> >> Fixes: 202ac22b8e2e ("power: supply: qcom_battmgr: Add lithium-polymer entry") >> Signed-off-by: Val Packett >> --- >> drivers/power/supply/qcom_battmgr.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c >> index c8028606bba0..80e701c66434 100644 >> --- a/drivers/power/supply/qcom_battmgr.c >> +++ b/drivers/power/supply/qcom_battmgr.c >> @@ -1240,7 +1240,8 @@ static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistry >> if ((!strncmp(chemistry, "LIO", BATTMGR_CHEMISTRY_LEN)) || >> (!strncmp(chemistry, "OOI", BATTMGR_CHEMISTRY_LEN))) >> return POWER_SUPPLY_TECHNOLOGY_LION; >> - if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN)) >> + if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN) || >> + (!strncmp(chemistry, "LiP", BATTMGR_CHEMISTRY_LEN))) > Why do you have extra brackets around the second strncmp? Copy-pasted from the line above (the "OOI" one) :) Didn't see that the first one in this expression doesn't have them. Feel free to edit this when applying ~val