From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A089CC432C0 for ; Fri, 29 Nov 2019 11:39:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8267B21774 for ; Fri, 29 Nov 2019 11:39:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726586AbfK2Ljc (ORCPT ); Fri, 29 Nov 2019 06:39:32 -0500 Received: from cloudserver094114.home.pl ([79.96.170.134]:58515 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726215AbfK2Ljc (ORCPT ); Fri, 29 Nov 2019 06:39:32 -0500 Received: from 79.184.255.242.ipv4.supernova.orange.pl (79.184.255.242) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.320) id 724467887e3930d8; Fri, 29 Nov 2019 12:39:30 +0100 From: "Rafael J. Wysocki" To: Anson Huang Cc: Viresh Kumar , Jacky Bai , "linux-pm@vger.kernel.org" Subject: Re: About CPU hot-plug stress test failed in cpufreq driver Date: Fri, 29 Nov 2019 12:39:30 +0100 Message-ID: <7507929.7xP3Io3WO9@kreacher> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Monday, November 25, 2019 1:44:20 PM CET Rafael J. Wysocki wrote: > On Mon, Nov 25, 2019 at 7:05 AM Anson Huang wrote: > > > > Hi, Rafael > > Looks like adding pr_info() in irq_work_sync() makes issue can NOT be reproduced, any possibility of race happen there and the pr_info eliminate the race condition? I will continue run the test with the pr_info to see if any luck to reproduce it. > > Yes, it looks like there is a race condition in there. > > I need to analyze the code a bit to confirm it which may take a bit of time. I'm not seeing any races in there expect for the possible over-optimization of irq_work_sync() that I was talking about before. Cheers!