From: Shuah <shuah@kernel.org>
To: Shuah Khan <skhan@linuxfoundation.org>, Meng Li <li.meng@amd.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Huang Rui <ray.huang@amd.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, linux-acpi@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Nathan Fontenot <nathan.fontenot@amd.com>,
Deepak Sharma <deepak.sharma@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Shimmer Huang <shimmer.huang@amd.com>,
Perry Yuan <Perry.Yuan@amd.com>,
Xiaojian Du <Xiaojian.Du@amd.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Borislav Petkov <bp@alien8.de>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH V7 0/7] amd-pstate preferred core
Date: Mon, 18 Sep 2023 12:23:27 -0600 [thread overview]
Message-ID: <757ecf2d-f544-1ab5-4d34-ece6a0eb1180@kernel.org> (raw)
In-Reply-To: <400a3e3e-4592-c947-a506-6baf1f268224@linuxfoundation.org>
On 9/18/23 11:44, Shuah Khan wrote:
> On 9/18/23 02:14, Meng Li wrote:
>> Hi all:
>>
>> The core frequency is subjected to the process variation in semiconductors.
>> Not all cores are able to reach the maximum frequency respecting the
>> infrastructure limits. Consequently, AMD has redefined the concept of
>> maximum frequency of a part. This means that a fraction of cores can reach
>> maximum frequency. To find the best process scheduling policy for a given
>> scenario, OS needs to know the core ordering informed by the platform through
>> highest performance capability register of the CPPC interface.
>>
>> Earlier implementations of amd-pstate preferred core only support a static
>> core ranking and targeted performance. Now it has the ability to dynamically
>> change the preferred core based on the workload and platform conditions and
>> accounting for thermals and aging.
>>
>> Amd-pstate driver utilizes the functions and data structures provided by
>> the ITMT architecture to enable the scheduler to favor scheduling on cores
>> which can be get a higher frequency with lower voltage.
>> We call it amd-pstate preferred core.
>>
>> Here sched_set_itmt_core_prio() is called to set priorities and
>> sched_set_itmt_support() is called to enable ITMT feature.
>> Amd-pstate driver uses the highest performance value to indicate
>> the priority of CPU. The higher value has a higher priority.
>>
>> Amd-pstate driver will provide an initial core ordering at boot time.
>> It relies on the CPPC interface to communicate the core ranking to the
>> operating system and scheduler to make sure that OS is choosing the cores
>> with highest performance firstly for scheduling the process. When amd-pstate
>> driver receives a message with the highest performance change, it will
>> update the core ranking.
>>
>> Changes form V6->V7:
>> - x86:
>> - - Modify kconfig about X86_AMD_PSTATE.
>> - cpufreq: amd-pstate:
>> - - modify incorrect comments about scheduler_work().
>> - - convert highest_perf data type.
>> - - modify preferred core init when cpu init and online.
>> - acpi: cppc:
>> - - modify link of CPPC highest performance.
>> - cpufreq:
>> - - modify link of CPPC highest performance changed.
>>
>
> This series in now in linux-kselftest next branch for Linux 6.7-rc1.
>
> If there are any changes and/or fixes, please send patches on top of
> linux-kselftest next branch.
>
Sorry for the mix-up. Wrong series - my bad. This series isn't
in linux-kselftest next.
thanks,
-- Shuah
next prev parent reply other threads:[~2023-09-18 18:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 8:14 [PATCH V7 0/7] amd-pstate preferred core Meng Li
2023-09-18 8:14 ` [PATCH V7 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion Meng Li
2023-09-18 8:14 ` [PATCH V7 2/7] acpi: cppc: Add get the highest performance cppc control Meng Li
2023-09-18 8:14 ` [PATCH V7 3/7] cpufreq: amd-pstate: Enable amd-pstate preferred core supporting Meng Li
2023-09-20 2:43 ` Huang Rui
2023-09-18 8:14 ` [PATCH V7 4/7] cpufreq: Add a notification message that the highest perf has changed Meng Li
2023-09-18 8:14 ` [PATCH V7 5/7] cpufreq: amd-pstate: Update amd-pstate preferred core ranking dynamically Meng Li
2023-09-18 8:14 ` [PATCH V7 6/7] Documentation: amd-pstate: introduce amd-pstate preferred core Meng Li
2023-09-18 8:14 ` [PATCH V7 7/7] Documentation: introduce amd-pstate preferrd core mode kernel command line options Meng Li
2023-09-18 17:40 ` [PATCH V7 0/7] amd-pstate preferred core Mario Limonciello
2023-09-19 0:50 ` Meng, Li (Jassmine)
2023-09-18 17:44 ` Shuah Khan
2023-09-18 18:23 ` Shuah [this message]
2023-09-19 19:01 ` Oleksandr Natalenko
2023-09-20 16:56 ` Mario Limonciello
2023-09-20 19:34 ` Oleksandr Natalenko
2023-09-20 20:11 ` Mario Limonciello
2023-09-21 5:51 ` Meng, Li (Jassmine)
2023-09-20 2:50 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=757ecf2d-f544-1ab5-4d34-ece6a0eb1180@kernel.org \
--to=shuah@kernel.org \
--cc=Perry.Yuan@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=alexander.deucher@amd.com \
--cc=bp@alien8.de \
--cc=deepak.sharma@amd.com \
--cc=li.meng@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nathan.fontenot@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ray.huang@amd.com \
--cc=shimmer.huang@amd.com \
--cc=skhan@linuxfoundation.org \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).