Linux Power Management development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Henrik Grimler <Henrik.Grimler@axis.com>
Cc: Kernel <Kernel@axis.com>,
	Alexander Svarvare <Alexander.Svarvare@axis.com>,
	"sebastian.reichel@collabora.com"
	<sebastian.reichel@collabora.com>, "afd@ti.com" <afd@ti.com>,
	"dmurphy@ti.com" <dmurphy@ti.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"pali@kernel.org" <pali@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"chris@lapa.com.au" <chris@lapa.com.au>,
	"sre@kernel.org" <sre@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] dt-bindings: power: bq27xxx: document bq27z746
Date: Mon, 17 Aug 2026 17:14:18 +0200	[thread overview]
Message-ID: <75eca5af-017e-4e6a-9e22-1e395be6e45a@kernel.org> (raw)
In-Reply-To: <bbd0548a01d7020947f025f0632a0994f4acd77d.camel@axis.com>

On 17/08/2026 17:00, Henrik Grimler wrote:
> Hi Krzysztof, 
> 
> Thanks for the comment!
> 
> On Mon, 2026-08-17 at 09:50 +0200, Krzysztof Kozlowski wrote:
>> On Tue, Aug 11, 2026 at 01:47:43PM +0200, Henrik Grimler wrote:
>>> Add compatible for Texas Instruments bq27z746 fuel gauge, which is
>>> similar to its sibling bqz27561, but with more protection
>>> functionality.
>>
>> "More" means superset? Driver code says it is compatible, so this has to
>> be explained 
> 
> I will update the commit message to explain the differences. Main
> difference is that bq27z746 has integrated protection logic, and can
> control external MOSFETs to stop charging/discharging if an issue is
> detected (like overcurrent or overvoltage), or to keep the rest of the
> system fully powered off in shipping mode. bq27z561 does not have such
> protection circuitry, so best it can do if it detects issues is to send
> an interrupt to some other component.
> 
> The standard register map is almost identical between the devices.
> bq27z561 has 6 extra registers at the end that bq27z746 lacks though,
> which I missed when comparing the TRMs the first time (so bq27z561 map
> is a superset of bq27z746's). Neither of these extra registers are
> supported/handled by the Linux driver through. I will update all the
> commit messages for v2 to clarify.
> 
> There are also additional "ManufacturerAccess" registers where there
> are some more differences between bq27z561 and bq27z746 mostly related
> to the above mentioned MOSFET control, but the current Linux driver
> does not read or handle any "ManufacturerAccess" register. One of my
> colleagues has sent a patch to add support for reading PROP_MODEL_NAME
> from these additional registers for bq27z561 though [1]. This model
> name register is the same for bq27z561 and bq27z746.
> 
> In summary the chips have differences, but I expect it will be fine for
> the driver to use same regs and props for bq27z746 and bq27z561.

Well, superset is exactly what compatibility is about.

Best regards,
Krzysztof

  reply	other threads:[~2026-08-17 15:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 11:47 [PATCH 0/5] power: supply: bq27xxx: add bq27z746, and fix some regs Henrik Grimler
2026-08-11 11:47 ` [PATCH 1/5] dt-bindings: power: bq27xxx: document bq27z746 Henrik Grimler
2026-08-17  7:50   ` Krzysztof Kozlowski
2026-08-17 15:00     ` Henrik Grimler
2026-08-17 15:14       ` Krzysztof Kozlowski [this message]
2026-08-11 11:47 ` [PATCH 2/5] power: supply: bq27xxx: add support for bq27z746 Henrik Grimler
2026-08-11 11:47 ` [PATCH 3/5] power: supply: bq27xxx: bq27520g4: fix REG_TTES address Henrik Grimler
2026-08-11 11:47 ` [PATCH 4/5] power: supply: bq27xxx: bq28z610: fix invalid AverageEnergy address Henrik Grimler
2026-08-11 11:47 ` [PATCH 5/5] power: supply: bq27xxx: bq27z561: " Henrik Grimler
2026-08-12 22:23 ` (subset) [PATCH 0/5] power: supply: bq27xxx: add bq27z746, and fix some regs Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75eca5af-017e-4e6a-9e22-1e395be6e45a@kernel.org \
    --to=krzk@kernel.org \
    --cc=Alexander.Svarvare@axis.com \
    --cc=Henrik.Grimler@axis.com \
    --cc=Kernel@axis.com \
    --cc=afd@ti.com \
    --cc=chris@lapa.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pali@kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox