Re: [RFC PATCH 2/6] cpufreq/amd-pstate: Add dynamic EPP as an "energy_performance_preference" mode

[K Prateek Nayak <kprateek.nayak@amd.com>]

Hello Mario,

Thank you for reviewing the series.

On 7/2/2026 3:03 AM, Mario Limonciello wrote:
>> +    /*
>> +     * Do not enumerate "dynamic" option only if disabled during boot.
>> +     * Users can still opt in to dynamic EPP if platform (server) has
>> +     * decided to keep it disabled by default.
>> +     */
> 
> As we're keeping it disabled for everyone right now, I think you can avoid disambiguating server for now.

Ack. This is just a stale comment from an older iteration. Sorry about
that and ack for rest of the comments too. Will fix in the next
version.

> 
>> +    if (!dynamic_epp)
>> +        max = EPP_INDEX_DYNAMIC;
>> +
>> +    for (i = 0; i < max; i++)
>>           offset += sysfs_emit_at(buf, offset, "%s ", energy_perf_strings[i]);
>>         offset += sysfs_emit_at(buf, offset, "\n");

-- 
Thanks and Regards,
Prateek