From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAEDBEB64DA for ; Wed, 5 Jul 2023 10:41:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230158AbjGEKlP (ORCPT ); Wed, 5 Jul 2023 06:41:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230049AbjGEKlO (ORCPT ); Wed, 5 Jul 2023 06:41:14 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EA62123 for ; Wed, 5 Jul 2023 03:41:13 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3143493728dso3796938f8f.1 for ; Wed, 05 Jul 2023 03:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688553672; x=1691145672; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=88goqqosTuFo/x96Kg4wKBh8UXMAznfyTlC2iZi5QZg=; b=VWkK2Ls2GShcm8rjv2v4WGq3q+Yhov40dgVPs4iOOhOnljFDm7SmgcHcSAka0mLq6h p3wmGmMd0SHzs19gR2JqgfVjUxu7X2keQXIO5NW2EXOZztzo2zoa8H3r0cd/HywQ22JS OqlHzCzuzmFNUS6KQwIpDLU0NqMtGvPWy6kIYGPmkC4KDQHaWREDZ8a+oytBqWj8JyNx jJdCfGV56ycJEtHOZRncxijPLU4+gDRuKqSGawmMkk/W9Pr8yYl1U/n91rsXgZEuSAw9 vDCbgXqMTVouFfXXMarLmrK3W/p7+ASjMRb6rHssrqCWhBBGDQHn9YDquveE1QMbPfPV aHcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688553672; x=1691145672; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=88goqqosTuFo/x96Kg4wKBh8UXMAznfyTlC2iZi5QZg=; b=CJrCvqu4OtRW1p9R6O6tqMgaqnsyFq/Ij79QnVOWWBJ3wybfYJrOMj4cqqYmOKZ83q GKEC/veMKgbkBjfG+m1NSfdnFx6MKs3h9W0P09ltruRbYotk04fc4dtaM/C6jvNo2vFv A/NteXqJfStB+3zqKIOLua+ab4yz/FkYbWPrZKv6COMd8iRIgR+kAslkJ7ZEWJ3dHs6A UzGMqcByvC6EhBBqBdD3IPa62GE5aMFVZwmGhqReS9/qIokHtr6C3RslSEXW1MFIp+c0 4dOyc7ASSgR+hJIx3EPmg1BNRbz2RH+5KrP78WD6AdSlRQbt+7tNboWpkg5DJFBn3U1n 5M+A== X-Gm-Message-State: ABy/qLZ6DIWZIGZp3/clx59dLHw07hhVsTvtgqwnEwEvevhg8E3ZSZx0 NnNUUjKEWTbSchmvLwd+3Ok6cA== X-Google-Smtp-Source: APBJJlF76X3ficyDs1/4Q++zss6/LXS7miOrOFC/V/Zbqi6qGsAVh719iwSI3BQ0uT/myXy+ikVTcA== X-Received: by 2002:a5d:4a47:0:b0:314:1096:ed2f with SMTP id v7-20020a5d4a47000000b003141096ed2fmr14313429wrs.35.1688553671880; Wed, 05 Jul 2023 03:41:11 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id l12-20020a5d668c000000b003143ac73fd0sm6364914wru.1.2023.07.05.03.41.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 03:41:11 -0700 (PDT) Message-ID: <77c90891-3712-4b3b-a22c-d9ccba36f58e@linaro.org> Date: Wed, 5 Jul 2023 12:41:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 5/8] thermal/drivers/int3400: Use thermal zone device wrappers Content-Language: en-US To: srinivas pandruvada Cc: linux-pm@vger.kernel.org, thierry.reding@gmail.com, Amit Kucheria , Zhang Rui , Jernej Skrabec , Baolin Wang , AngeloGioacchino Del Regno , "Lee, Chun-Yi" , ye xingchen , open list , rafael@kernel.org References: <20230525140135.3589917-1-daniel.lezcano@linaro.org> <20230525140135.3589917-6-daniel.lezcano@linaro.org> <74c232550c6787ef34ddac67a61339e6c028fb0d.camel@linux.intel.com> From: Daniel Lezcano In-Reply-To: <74c232550c6787ef34ddac67a61339e6c028fb0d.camel@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Srinivas, thanks for your answer. What about the patch 6? On 03/07/2023 18:15, srinivas pandruvada wrote: > Hi Daniel, > > On Mon, 2023-07-03 at 12:49 +0200, Daniel Lezcano wrote: >> >> Hi Srinivas, >> >> do you agree with the changes in patches 5 and 6 ? >> >> Thanks >> >>    -- Daniel >> >> >> On 25/05/2023 16:01, Daniel Lezcano wrote: >>> The driver is accessing the thermal zone device structure but the >>> accessors are already existing and we want to consolidate the >>> thermal >>> core code by preventing accesses to the internals from the drivers. >>> >>> Let's use these accessors. >>> >>> On the other side, the code is getting directly the temperature >>> from >>> tz->temperature, but the temperature is a faked on, so we can >>> replace >>> this access by the fake temp and remove the thermal zone device >>> structure access. >>> > May be something simple description like this will be enough. > > " > Use thermal core API to access thermal zone "type" field instead of > directly using the structure field. > While here, remove access to temperature field, as this driver is > reporting fake temperature, which can be replaced with > INT3400_FAKE_TEMP. Also replace hardcoded 20C with INT3400_FAKE_TEMP. > " > > The change itself looks fine. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog