From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5903DC74A5B for ; Wed, 29 Mar 2023 16:03:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230090AbjC2QCq (ORCPT ); Wed, 29 Mar 2023 12:02:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231319AbjC2QB4 (ORCPT ); Wed, 29 Mar 2023 12:01:56 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E195E3A8E for ; Wed, 29 Mar 2023 09:00:44 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id m2so16279810wrh.6 for ; Wed, 29 Mar 2023 09:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680105630; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ArwpNVIf9POAixbklkhIv67If2EwgIZ+QA4ChZDwYgE=; b=Idh5bizNTidzmJWpFEgi4q88BF2+/lO675pVeMaNsr8ygV36SvVkmWzi+QBNiYJKu6 tF5oIdEWoj9xksHV/Xh4B2dTuZbzjgbBCTkwp67pEUOiif8JVbwKT2DIsUJd9GVb3CRo 47Rj6TldHbceb66V68BIp976mKiukc2vkMUla6L7tV9MGqQ4sf2ibQf0WoYH9bCeSFGq NIOlXf1sFNwfiWODEiK8SIJcHA+NJ8UbpqrP+yLm2t/qnphTwYpc6Chxnlotla+7lUiZ lkvuRshIJgjHnsBbpXYjPnD6tIKAeDfnYY1juoZlKdm7rN1zNc6YRdEEtKEaEyhdGSwf yO0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680105630; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ArwpNVIf9POAixbklkhIv67If2EwgIZ+QA4ChZDwYgE=; b=RjhUU7oN5mN281+XVLrcC0ApCKsS8rztkZmX5EhvQnh/YgZEiASThaXMi5CTDywQFj 9VwOCJSpxB2qdHf16Q87CFYvezdob2MWNiz6WjVyRWa/dVnwCzax44FygGMbMXOJOGtx o942EqzfGlvNHKKyhkMdzvd5ae3lO82adXYyZyEwz+OvuXzGhxpvcOel3Q9IDfBND7lb l7+RUWhb9+3MZJMy4aS3Ee37FowV8l293cmOUTNUNLfX+4glL7cC2eZFlM70bp7m7qqi ZdTSo+jLJlSQp0vGSfwG8LciQHN3OTyuH6jML5RAXtcuLfBnvuCHy5SgdG0pMFlCtET9 fI7Q== X-Gm-Message-State: AAQBX9fIHZeR8/+b7pjuunDAsapcf1ngTIe89cgYI1G+MO2dIoJryvd/ wUsbCKqCnGsY5LRk6VUSbkNRlN5iwQMwZ3sx5rE= X-Google-Smtp-Source: AKy350bmfLsfH9MB3jVTmKwHrCdVGLJBaNHbyMMHil+19zF7gmCcgdeO3qEC0rHmFr/2uB1iBH/aJA== X-Received: by 2002:a5d:4588:0:b0:2cf:ed87:37c9 with SMTP id p8-20020a5d4588000000b002cfed8737c9mr2251984wrq.11.1680105629985; Wed, 29 Mar 2023 09:00:29 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:7c0e:2838:74e9:d05? ([2a05:6e02:1041:c10:7c0e:2838:74e9:d05]) by smtp.googlemail.com with ESMTPSA id b9-20020adfde09000000b002daeb108304sm17446206wrm.33.2023.03.29.09.00.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Mar 2023 09:00:29 -0700 (PDT) Message-ID: <77da9d68-3cb2-f765-21d2-e427776dca44@linaro.org> Date: Wed, 29 Mar 2023 18:00:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH -next] thermal/drivers/thermal_hwmon: Fix a kernel NULL pointer dereference Content-Language: en-US To: Zhang Rui , linux-pm@vger.kernel.org, rafael.j.wysocki@intel.com Cc: linux-kernel@vger.kernel.org References: <20230329090055.7537-1-rui.zhang@intel.com> From: Daniel Lezcano In-Reply-To: <20230329090055.7537-1-rui.zhang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 29/03/2023 11:00, Zhang Rui wrote: > When the hwmon device node of a thermal zone device is not found, > using hwmon->device causes a kernel NULL pointer dereference. > > Reported-by: Preble Adam C > Signed-off-by: Zhang Rui Acked-by: Daniel Lezcano > --- > Fixes: dec07d399cc8 ("thermal: Don't use 'device' internal thermal zone structure field") > dec07d399cc8 is a commit in the linux-next branch of linux-pm repo. > I'm not sure if the Fix tag applies to such commit or not. > --- > drivers/thermal/thermal_hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c > index c59db17dddd6..261743f461be 100644 > --- a/drivers/thermal/thermal_hwmon.c > +++ b/drivers/thermal/thermal_hwmon.c > @@ -229,7 +229,7 @@ void thermal_remove_hwmon_sysfs(struct thermal_zone_device *tz) > hwmon = thermal_hwmon_lookup_by_type(tz); > if (unlikely(!hwmon)) { > /* Should never happen... */ > - dev_dbg(hwmon->device, "hwmon device lookup failed!\n"); > + dev_dbg(&tz->device, "hwmon device lookup failed!\n"); > return; > } > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog