From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E65192561D; Thu, 6 Feb 2025 06:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.190 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738823275; cv=none; b=crMrpwaqngQD7/YcAkZGrnbut1evD0sGR8dgsxafIn00ZsMo6JPGRBql0p1cYh7uRHJ9dqdkyOXJHqX7htwi9OS44uIT6GqUmzwQXHcwztN459Aiu2+7jorEQoPyYZIOZhfykokKmj02shk9EZ0iEDOxNtuwimORXwIzF2Ra8Co= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738823275; c=relaxed/simple; bh=YBHaTZW+tpKp36RzIrAFZSbRfY45BlzSnxis70lzJM8=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=c9nGgK6QNkrEeJc6u2OPQvMndeXxeHupk44SbtMXoS00sW6ub/7ndUtbAgjuYI4twRxE42xhKT7ygIBZzOBJx/sdNacdusy2Xq0bmAonevEHTZoWrGP2ljAFOS9hXHCT6sKF8TXxWFc0ObWm9oKMer2ovqN77JE3sc1hxaJfSWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4YpRsm60Jrz22mPq; Thu, 6 Feb 2025 14:25:00 +0800 (CST) Received: from kwepemh100008.china.huawei.com (unknown [7.202.181.93]) by mail.maildlp.com (Postfix) with ESMTPS id 04AF41A016C; Thu, 6 Feb 2025 14:27:47 +0800 (CST) Received: from [10.67.121.90] (10.67.121.90) by kwepemh100008.china.huawei.com (7.202.181.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 6 Feb 2025 14:27:46 +0800 Message-ID: <78c6dbea-ccbc-4380-a6e9-96dd76deb999@huawei.com> Date: Thu, 6 Feb 2025 14:27:45 +0800 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/15] cpufreq: cppc: Set policy->boost_supported To: Viresh Kumar , "Rafael J. Wysocki" CC: , Vincent Guittot , References: From: "zhenglifeng (A)" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh100008.china.huawei.com (7.202.181.93) On 2025/1/24 16:58, Viresh Kumar wrote: > With a later commit, the cpufreq core will call the ->set_boost() > callback only if the policy supports boost frequency. The > boost_supported flag is set by the cpufreq core if policy->freq_table is > set and one or more boost frequencies are present. > > For other drivers, the flag must be set explicitly. > > With this, the local variable boost_supported isn't required anymore. > > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/cppc_cpufreq.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c > index 7fa89b601d2a..08117fb9c1eb 100644 > --- a/drivers/cpufreq/cppc_cpufreq.c > +++ b/drivers/cpufreq/cppc_cpufreq.c > @@ -34,8 +34,6 @@ > */ > static LIST_HEAD(cpu_data_list); > > -static bool boost_supported; > - > static struct cpufreq_driver cppc_cpufreq_driver; > > #ifdef CONFIG_ACPI_CPPC_CPUFREQ_FIE > @@ -653,7 +651,7 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) > * is supported. > */ > if (caps->highest_perf > caps->nominal_perf) > - boost_supported = true; > + policy->boost_supported = true; > > /* Set policy->cur to max now. The governors will adjust later. */ > policy->cur = cppc_perf_to_khz(caps, caps->highest_perf); > @@ -791,11 +789,6 @@ static int cppc_cpufreq_set_boost(struct cpufreq_policy *policy, int state) > struct cppc_perf_caps *caps = &cpu_data->perf_caps; > int ret; > > - if (!boost_supported) { > - pr_err("BOOST not supported by CPU or firmware\n"); > - return -EINVAL; > - } > - > if (state) > policy->max = cppc_perf_to_khz(caps, caps->highest_perf); > else Reviewed-by: Lifeng Zheng