From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Nicolas Pitre <npitre@baylibre.com>
Cc: Julien Panis <jpanis@baylibre.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Return error in case of invalid efuse data
Date: Wed, 5 Jun 2024 12:33:59 +0200 [thread overview]
Message-ID: <7a5679f1-04a9-490e-ad9d-8f7e706c90cf@collabora.com> (raw)
In-Reply-To: <359n7s98-08p8-177q-n51s-33rs215soqq2@onlyvoer.pbz>
Il 04/06/24 18:33, Nicolas Pitre ha scritto:
> On Tue, 4 Jun 2024, AngeloGioacchino Del Regno wrote:
>
>> Il 03/06/24 14:06, Julien Panis ha scritto:
>>> This patch prevents from registering thermal entries and letting the
>>> driver misbehave if efuse data is invalid. A device is not properly
>>> calibrated if the golden temperature is zero.
>>>
>>> Signed-off-by: Julien Panis <jpanis@baylibre.com>
>>
>> Fixes tag, please.
>
> What should it refer to? This is arguably a robustness enhancement for a
> defficiency that has been there all along.
>
>
If that's been there since day 1, the fixes tag should be the day 1 commit,
of course.
I see that as an important bugfix and not just a robustness enhancement, as
SoCs with uncalibrated LVTS would *not work*, as the kernel would shut down
the system before even loading the userspace.
Regards,
Angelo
prev parent reply other threads:[~2024-06-05 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 12:06 [PATCH] thermal/drivers/mediatek/lvts_thermal: Return error in case of invalid efuse data Julien Panis
2024-06-04 16:19 ` Nicolas Pitre
2024-06-04 16:26 ` Daniel Lezcano
2024-06-04 16:29 ` AngeloGioacchino Del Regno
2024-06-04 16:33 ` Nicolas Pitre
2024-06-05 10:33 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a5679f1-04a9-490e-ad9d-8f7e706c90cf@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=daniel.lezcano@linaro.org \
--cc=jpanis@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=npitre@baylibre.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox