From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH 3/3] arm: dts: thermal: add thermal/auxadc node. Date: Mon, 22 Aug 2016 19:09:56 +0200 Message-ID: <7a7684dc-aea5-15f8-04fb-494b2085a3fe@gmail.com> References: <1467882386-40544-1-git-send-email-dawei.chien@mediatek.com> <1467882386-40544-4-git-send-email-dawei.chien@mediatek.com> <1471245268.14287.14.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1471245268.14287.14.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: dawei chien Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Pawel Moll , Ian Campbell , Erin Lo , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Eduardo Valentin , Fan Chen , Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sascha Hauer , Kumar Gala , Yingjoe Chen , Zhang Rui , Eddie Huang , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-pm@vger.kernel.org On 15/08/16 09:14, dawei chien wrote: > Hi Matthias, > > On Thu, 2016-08-11 at 17:51 +0200, Matthias Brugger wrote: >> >> On 07/07/16 11:06, Dawei Chien wrote: >>> This adds the thermal controller and auxadc nodes >>> to the Mediatek MT2701 dtsi file. >>> >>> Signed-off-by: Dawei Chien >>> --- >>> This patch depned on: >>> https://patchwork.kernel.org/patch/9213545/ >>> --- >>> arch/arm/boot/dts/mt2701.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 43 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi >>> index 2ac8b50..0834a23 100644 >>> --- a/arch/arm/boot/dts/mt2701.dtsi >>> +++ b/arch/arm/boot/dts/mt2701.dtsi >>> @@ -77,6 +77,36 @@ >>> #clock-cells = <0>; >>> }; >>> >>> + thermal-zones { >>> + cpu_thermal: cpu_thermal { >>> + polling-delay-passive = <1000>; /* milliseconds */ >>> + polling-delay = <1000>; /* milliseconds */ >>> + >>> + thermal-sensors = <&thermal 0>; >>> + sustainable-power = <1000>; >>> + >>> + trips { >>> + threshold: trip-point@0 { >>> + temperature = <68000>; >>> + hysteresis = <2000>; >>> + type = "passive"; >>> + }; >>> + >>> + target: trip-point@1 { >>> + temperature = <85000>; >>> + hysteresis = <2000>; >>> + type = "passive"; >>> + }; >>> + >>> + cpu_crit: cpu_crit@0 { >>> + temperature = <115000>; >>> + hysteresis = <2000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + }; >>> + >>> timer { >>> compatible = "arm,armv7-timer"; >>> interrupt-parent = <&gic>; >>> @@ -183,4 +213,17 @@ >>> clocks = <&uart_clk>; >>> status = "disabled"; >>> }; >>> + >>> + thermal: thermal@1100b000 { >>> + #thermal-sensor-cells = <0>; >>> + compatible = "mediatek,mt2701-thermal"; >>> + reg = <0 0x1100b000 0 0x1000>; >>> + interrupts = ; >>> + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; >>> + clock-names = "therm", "auxadc"; >>> + resets = <&pericfg 0x10>; >>> + reset-names = "therm"; >>> + mediatek,auxadc = <&auxadc>; >>> + mediatek,apmixedsys = <&apmixedsys>; >>> + }; >>> }; >>> >> >> what about: >> status = "disabled"; ? > > Since thermal driver would protect our platform by shutdown method once > SoC temperature over critical point, I prefer keep this rather than > disabling, how do you think, thank you. > Sounds reasonable. Thanks