From: Viresh Kumar <viresh.kumar@linaro.org>
To: rjw@rjwysocki.net
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, arvind.chauhan@arm.com,
inderpal.s@samsung.com, nm@ti.com, chander.kashyap@linaro.org,
pavel@ucw.cz, len.brown@intel.com, sudeep.holla@arm.com,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V3 2/8] opp: of_init_opp_table(): return -ENOSYS when feature isn't implemented
Date: Thu, 22 May 2014 11:07:26 +0530 [thread overview]
Message-ID: <7ad59da5b28e8ed632e833fa5095129628bd8deb.1400736536.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1400736536.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1400736536.git.viresh.kumar@linaro.org>
When none of CONFIG_PM_OPP or CONFIG_OF is enabled we use the dummy
implementation of of_init_opp_table() routine, which returns -EINVAL currently.
-EINVAL can confuse the callers a bit as it can have other meanings for the
actual implementation of this routine.
It is more appropriate to return -ENOSYS instead to avoid confusion at caller.
Suggested-and-reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
include/linux/pm_opp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h
index 0330217..6668150 100644
--- a/include/linux/pm_opp.h
+++ b/include/linux/pm_opp.h
@@ -112,7 +112,7 @@ int of_init_opp_table(struct device *dev);
#else
static inline int of_init_opp_table(struct device *dev)
{
- return -EINVAL;
+ return -ENOSYS;
}
#endif
--
2.0.0.rc2
next prev parent reply other threads:[~2014-05-22 5:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 5:37 [PATCH V3 0/8] CPUFreq: Initialize CPU's OPP tables from CPU core Viresh Kumar
2014-05-22 5:37 ` [PATCH V3 1/8] cpufreq: cpufreq-cpu0: remove dependency on thermal Viresh Kumar
2014-05-22 14:52 ` Eduardo Valentin
2014-05-23 4:33 ` Viresh Kumar
2014-05-23 13:21 ` Eduardo Valentin
2014-05-23 13:28 ` Viresh Kumar
2014-05-24 12:59 ` Pavel Machek
2014-05-26 4:04 ` Viresh Kumar
2014-05-22 5:37 ` Viresh Kumar [this message]
2014-05-22 5:37 ` [PATCH V3 3/8] opp: call of_node_{get|put}() from of_init_opp_table() Viresh Kumar
2014-05-22 5:37 ` [PATCH V3 4/8] driver/core: cpu: initialize opp table Viresh Kumar
2014-05-26 23:32 ` Rafael J. Wysocki
2014-05-27 0:04 ` Viresh Kumar
2014-05-27 0:18 ` Viresh Kumar
2014-05-27 11:30 ` Rafael J. Wysocki
2014-05-22 5:37 ` [PATCH V3 5/8] cpufreq: arm_big_little: don't " Viresh Kumar
2014-05-22 5:37 ` [PATCH V3 6/8] cpufreq: imx6q: " Viresh Kumar
2014-05-22 5:37 ` [PATCH V3 7/8] cpufreq: cpufreq-cpu0: " Viresh Kumar
2014-05-22 5:37 ` [PATCH V3 8/8] cpufreq: exynos5440: " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ad59da5b28e8ed632e833fa5095129628bd8deb.1400736536.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=arvind.chauhan@arm.com \
--cc=chander.kashyap@linaro.org \
--cc=inderpal.s@samsung.com \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).