From: Dmitry Osipenko <digetx@gmail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Peter Chen <peter.chen@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>, David Heidelberg <david@ixit.cz>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 05/12] usb: otg-fsm: Fix hrtimer list corruption
Date: Sat, 10 Jul 2021 00:30:56 +0300 [thread overview]
Message-ID: <7b0940a9-ea65-d83e-7450-a09a0082bcd5@gmail.com> (raw)
In-Reply-To: <YOd/SfxC26esmVXU@qmqm.qmqm.pl>
09.07.2021 01:42, Michał Mirosław пишет:
> On Thu, Jul 01, 2021 at 05:23:58AM +0300, Dmitry Osipenko wrote:
>> The HNP work can be re-scheduled while it's still in-fly. This results in
>> re-initialization of the busy work, resetting the hrtimer's list node of
>> the work and crashing kernel with null dereference within kernel/timer
>> once work's timer is expired. It's very easy to trigger this problem by
>> re-plugging USB cable quickly. Initialize HNP work only once to fix this
>> trouble.
> [...]
>> - INIT_DELAYED_WORK(&fsm->hnp_polling_work, otg_hnp_polling_work);
>> + if (!fsm->hnp_work_inited) {
>> + INIT_DELAYED_WORK(&fsm->hnp_polling_work, otg_hnp_polling_work);
>> + fsm->hnp_work_inited = true;
>> + }
>> +
>
> Maybe you could just add an initialization function to be called by
> users of otg_fsm? It seems that only chipidea driver uses this
> struct currently.
If there are any out-of-tree users of the OTG FSM, then they will all
get the fix too using the universal solution.
next prev parent reply other threads:[~2021-07-09 21:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 2:23 [PATCH v1 00/12] Add OTG mode support to Tegra USB PHY, SMB347 and Nexus 7 Dmitry Osipenko
2021-07-01 2:23 ` [PATCH v1 01/12] dt-bindings: phy: tegra20-usb-phy: Convert to schema Dmitry Osipenko
2021-07-01 2:23 ` [PATCH v1 02/12] dt-bindings: phy: tegra20-usb-phy: Document properties needed for OTG mode Dmitry Osipenko
2021-07-01 2:23 ` [PATCH v1 03/12] soc/tegra: pmc: Expose USB regmap to all SoCs Dmitry Osipenko
2021-07-01 2:23 ` [PATCH v1 04/12] usb: phy: tegra: Support OTG mode programming Dmitry Osipenko
2021-07-01 13:55 ` Dmitry Osipenko
2021-07-08 22:32 ` Michał Mirosław
2021-07-09 21:29 ` Dmitry Osipenko
2021-07-01 2:23 ` [PATCH v1 05/12] usb: otg-fsm: Fix hrtimer list corruption Dmitry Osipenko
2021-07-08 22:42 ` Michał Mirosław
2021-07-09 21:30 ` Dmitry Osipenko [this message]
2021-07-01 2:23 ` [PATCH v1 06/12] dt-bindings: power: supply: smb347-charger: Document USB VBUS regulator Dmitry Osipenko
2021-07-01 2:24 ` [PATCH v1 07/12] power: supply: smb347-charger: Make smb347_set_writable() IRQ-safe Dmitry Osipenko
2021-07-01 2:24 ` [PATCH v1 08/12] power: supply: smb347-charger: Remove caching of charger state Dmitry Osipenko
2021-07-01 2:24 ` [PATCH v1 09/12] power: supply: smb347-charger: Implement USB VBUS regulator Dmitry Osipenko
2021-07-01 2:24 ` [PATCH v1 10/12] arm64: tegra132: Add new properties to USB PHY device-tree node Dmitry Osipenko
2021-07-01 2:24 ` [PATCH v1 11/12] ARM: tegra: Add new properties to USB PHY device-tree nodes Dmitry Osipenko
2021-07-01 2:24 ` [PATCH v1 12/12] ARM: tegra: nexus7: Enable USB OTG mode Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b0940a9-ea65-d83e-7450-a09a0082bcd5@gmail.com \
--to=digetx@gmail.com \
--cc=balbi@kernel.org \
--cc=broonie@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=peter.chen@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).