From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6EF93D2FE1 for ; Wed, 22 Apr 2026 11:59:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776859163; cv=none; b=d2Tdj3d7hpFRf1hiquKjvCIOcrNTmJhv8oiLAMkt2b1ClTOuv6o3atVEQ8UsYsnry6neSYAP1QqUBqOj4siX5p8gZh63rEr4E9QCVJFmGoS3lcdSrN8Vtkkir8FZhBu+jTPaB76tx9wRNlmXyJxJ2tjN5ExhPNcHo+RN1F8puAY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776859163; c=relaxed/simple; bh=PxxWuD2DAnmLuzpLFkG5DbUWJB0P/Lom4mu12j2Y8t8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bJcUTPboPc4NtyJgUpWr1yC6VJaIlapWlB7I5H96XNFVebHZTDIYWdR33YbRb3SF390jAr4JmC29YgkaynEVXjYPvJocnr0e1cn1U+AKwSrNP07k16ZUMbJB9zFhn+6LrsOmi0ZQZ6Y6rCQ9pn1lq5Gp2E8Gt9VkqjsdPa1XfIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Uun2H9H9; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Uun2H9H9" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2aaf59c4f7cso24661595ad.1 for ; Wed, 22 Apr 2026 04:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776859161; x=1777463961; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=yQdjvNpFoN4+Y1Foq/Arcrd5LT5ufq6D54+4yF+FPEo=; b=Uun2H9H9u6S5WrW3FY+Daa+m4wxYIIOox/vp7Kn3Dz5C1JnuOrz3nQswel6dLY69ud xbr/YqGjLW5LMtm3LZjuwc70QcBTqeoirIsq9lwJbadckirRTW9La+qosSPi/zij0v0n bAkoecTLab5IVEnMS7CfLcHhC/DIZnM8j9ngA2pROd561tRxIzjGAqlM0GlkQr49EIB8 gWwwLgpj/tWyXu2JjAFO2TUxKmOLSH+sZq0KTQFqeZKx4dmRQLoeR2ItvDnwm7O43lWZ pFTCk8VlSarIl/OUfPUMGcJf8x5vqhElgeeHt0tgNrk1g0b3H8Qn9J+IbTjzGQZmlV9R 9+Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776859161; x=1777463961; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yQdjvNpFoN4+Y1Foq/Arcrd5LT5ufq6D54+4yF+FPEo=; b=THtkjvlAXHyVpkIlmQdZ/VmEk1AdUTTsEGoDVm4fdC0OJWVOOfIcbUK9DZKxfbh7io 7fN90Nr7X4fsW0GHgaZGbFKjM4zW4veDQXGF5bP/ZVJhCDlk3ce2cILeO+m/gdwEB2Fd d2T82xPMRAcWQgrN9pzacmU/SjyubcLqftyK5XgUV6AhGa6ULMU5p1HsOdGfpDpfGRiW WDniNGA3QEXIVPJfbQJjwhrY7nwla/2+JrTnOwQE0eotasuNS2EZorQsKk/PIXhf8RzE R56yViDHG+SutJPVytdvSQYKncemn1duTP7eytFm8yKzmLqjwWjf6ab5me4HlutCHfvl IB9Q== X-Forwarded-Encrypted: i=1; AFNElJ97NOf6/0H1TQrgLKT00isBAEXmxEHUvqF7uKuK5W4TPh3fEDm23xh2JZ/le3H0o4S7vKmygKeW4g==@vger.kernel.org X-Gm-Message-State: AOJu0YwHqlhYE0CSV5p12ZoC3n1oarCqVmT0Re/99bPZ+R+u3alX4yOc Bm01soQEb5Py5rpEqGrr5/L92BFqhurHLe3KWab3eBeymn6gxDqU9Ur6 X-Gm-Gg: AeBDiese9BLdVs0CptE4f/z1RHPNvSSsCHAHihZblhaWDXcpeBHKOxbu0eIq7N18JHG Du6XwfRKC6+2t+BvLh7og3Otbr+HnY/sJHrzy3D8qTWvdt4mm0wF26fxYjE6HRr4kMvjvuDt4Of 7Or+skY7dzfhQrf4pnNA6RUx/OkuDX/AjTkhczyEYlDE4ZRAuaCBc4ApN45NGUhpZAPJN7nyfFi L0gcO6JtLFzQxpyxwyTdLtMnEV6Jsc8eeaGC2mc0qiUz3FiRcXtUdTlkSfOOcXWX4H9VKj4p1Lu iY6XRva/hDgDf+bnWVQwbKUmLm0j3uAxqETiN3OszFnr6+g8KKjBg+CVqgcaWGAI955XV7ZcIsp XWy9pA4T9u9O0tPxWGJX7zBQp3nzVcwAJJInjkNOVU1YL1vqLtY0ctdvO83D78k3m8tUtB4UO7U NBcSdvQ/JNx4/tCjHBiHNWWEiQub2he9EFyfFGkZccFNffOsf2pXiwKGFOztp49bUECjHY59Q3A oXSDtV3MyU= X-Received: by 2002:a17:903:8c4:b0:2b0:61c2:8e7a with SMTP id d9443c01a7336-2b5f9f1c601mr217544535ad.25.1776859161266; Wed, 22 Apr 2026 04:59:21 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cdd1sm164231655ad.38.2026.04.22.04.59.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 04:59:20 -0700 (PDT) Sender: Guenter Roeck Message-ID: <7e4a008b-74c9-40fa-8fff-ee4fa830e3dd@roeck-us.net> Date: Wed, 22 Apr 2026 04:59:17 -0700 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/14] hwmon:: Use non-OF thermal cooling device register function To: Daniel Lezcano , rafael@kernel.org Cc: gaurav.kohli@oss.qualcomm.com, Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lucas Stach , Russell King , Christian Gmeiner , David Airlie , Simona Vetter , Joel Stanley , Andrew Jeffery , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Benson Leung , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Heiko Stuebner , Thierry Reding , Jonathan Hunter , Bjorn Andersson , Konrad Dybcio , Amit Daniel Kachhap , Viresh Kumar , Neil Armstrong , Amit Kucheria , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, "open list:CHROMEOS EC HARDWARE MONITORING" References: <20260419182203.4083985-1-daniel.lezcano@oss.qualcomm.com> <20260419182203.4083985-8-daniel.lezcano@oss.qualcomm.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260419182203.4083985-8-daniel.lezcano@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/19/26 11:21, Daniel Lezcano wrote: > Make HWMON drivers which are not based on device tree to use the > corresponding non-OF functions. > > Signed-off-by: Daniel Lezcano Acked-by: Guenter Roeck > --- > drivers/hwmon/cros_ec_hwmon.c | 4 ++-- > drivers/hwmon/dell-smm-hwmon.c | 4 ++-- > drivers/hwmon/mlxreg-fan.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwmon/cros_ec_hwmon.c b/drivers/hwmon/cros_ec_hwmon.c > index 6cf5ab0f4b73..77dd9f28962d 100644 > --- a/drivers/hwmon/cros_ec_hwmon.c > +++ b/drivers/hwmon/cros_ec_hwmon.c > @@ -532,8 +532,8 @@ static void cros_ec_hwmon_register_fan_cooling_devices(struct device *dev, > > cpriv->hwmon_priv = priv; > cpriv->index = i; > - cdev = devm_thermal_of_cooling_device_register(dev, NULL, type, cpriv, > - &cros_ec_thermal_cooling_ops); > + cdev = devm_thermal_cooling_device_register(dev, type, cpriv, > + &cros_ec_thermal_cooling_ops); > if (IS_ERR(cdev)) { > dev_warn(dev, "failed to register fan %zu as a cooling device: %pe\n", i, > cdev); > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c > index 038edffc1ac7..47b373ea6db4 100644 > --- a/drivers/hwmon/dell-smm-hwmon.c > +++ b/drivers/hwmon/dell-smm-hwmon.c > @@ -1161,8 +1161,8 @@ static int dell_smm_init_cdev(struct device *dev, u8 fan_num) > if (cdata) { > cdata->fan_num = fan_num; > cdata->data = data; > - cdev = devm_thermal_of_cooling_device_register(dev, NULL, name, cdata, > - &dell_smm_cooling_ops); > + cdev = devm_thermal_cooling_device_register(dev, name, cdata, > + &dell_smm_cooling_ops); > if (IS_ERR(cdev)) { > devm_kfree(dev, cdata); > ret = PTR_ERR(cdev); > diff --git a/drivers/hwmon/mlxreg-fan.c b/drivers/hwmon/mlxreg-fan.c > index 137a90dd2075..860de6cfd8a4 100644 > --- a/drivers/hwmon/mlxreg-fan.c > +++ b/drivers/hwmon/mlxreg-fan.c > @@ -583,8 +583,8 @@ static int mlxreg_fan_cooling_config(struct device *dev, struct mlxreg_fan *fan) > pwm->fan = fan; > /* Set minimal PWM speed. */ > pwm->last_hwmon_state = MLXREG_FAN_PWM_DUTY2STATE(MLXREG_FAN_MIN_DUTY); > - pwm->cdev = devm_thermal_of_cooling_device_register(dev, NULL, mlxreg_fan_name[i], > - pwm, &mlxreg_fan_cooling_ops); > + pwm->cdev = devm_thermal_cooling_device_register(dev, mlxreg_fan_name[i], > + pwm, &mlxreg_fan_cooling_ops); > if (IS_ERR(pwm->cdev)) { > dev_err(dev, "Failed to register cooling device\n"); > return PTR_ERR(pwm->cdev);